-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use a lighter style for <kbd>
#536
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, I am not so sure whether it is good to include it in asset/css/markbind.css
(which will affect all MarkBind websites), rather than in docs/css/main.css
(which will only affect our documentation website).
I am fine with the current way as it is, unless there's some objection similar to above.
Although not in the scope of this PR, should we support both light and dark themed I feel its ok to override the |
👍
That can be considered, although I am not an expert in css so I was wondering what you had in mind for that kind of implementation. I was thinking that if the author is going to use their own |
@yamgent it would be pretty straightforward to have a |
Theming files might be better. See discussion in #386. For example, we could put this override in a theme-light.css and include it by default. |
What is the purpose of this pull request? (put "X" next to an item, remove the rest)
• [X] Enhancement to an existing feature
Fixes #532.
What is the rationale for this request?
The current style for
<kbd>
is white on black text, which gives it too much contrast relative to its surrounding content:What changes did you make? (Give an overview)
The style of
<kbd>
was changed to use a lighter, black on white style instead:Provide some example code that this change will affect:
Testing instructions:
<kbd>
tag on a MarkBind page. It should render with the new, lighter style.