-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show anchor links for each heading #433
Conversation
This seems kind of troublesome if there's a lot of such pages (if not all) in the website though (slightly similar to #389). Was wondering whether we should add a default option in |
Design in the example gif looks fine actually. 👍 |
Maybe no need for this to be configurable? i.e., we do it by default for all headings |
That sounds good too. |
734a32a
to
8310b6f
Compare
Updated to solve merge conflict and automatically add anchors |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested the feature, works fine 👍.
14c5e49
to
37805b3
Compare
Updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor nit
37805b3
to
8fd37d3
Compare
What is the purpose of this pull request? (put "X" next to an item, remove the rest)
• [X] New feature
Fixes #426
What is the rationale for this request?
Users may want to share a link to a specific heading with others.
What changes did you make? (Give an overview)
Allow users to automatically generate anchor links for each heading that direct the URL to that heading.
Provide some example code that this change will affect:
Users must include an
anchors
property in thefrontmatter
:anchors: true
Functions similar to https://developers.timekit.io/v2/reference#section-root-endpoint-versions-and-protocol
Is there anything you'd like reviewers to focus on?
Should we make the behavior different from the example site (e.g. change the icon)?