-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add note on absolute links #2507
Merged
Merged
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
80be602
Add note on absolute links
jingting1412 6e3617b
Fix typos
jingting1412 92000fe
Merge branch 'MarkBind:master' into popup-docs
jingting1412 37dae13
Add tip to more pages
jingting1412 337ec36
Merge branch 'MarkBind:master' into popup-docs
jingting1412 fc0e857
Update docs/userGuide/syntax/includes.md
jingting1412 7f25bb9
Update docs/userGuide/syntax/includes.md
jingting1412 c9f1a47
Add negative example
jingting1412 cf4251f
Merge branch 'MarkBind:master' into popup-docs
jingting1412 ac5bc63
Merge branch 'MarkBind:master' into popup-docs
jingting1412 0fd7aa1
Update docs/userGuide/troubleshooting.md
jingting1412 5a2bb07
Update docs/userGuide/syntax/includes.md
jingting1412 1f207ee
Update docs/userGuide/syntax/includes.md
jingting1412 cdd953c
Update docs/userGuide/syntax/includes.md
jingting1412 ed502e8
Add more details
jingting1412 686e19b
Improve explanation
jingting1412 ced6b4d
Merge branch 'MarkBind:master' into popup-docs
jingting1412 edfd5b0
Improve look of tip
jingting1412 9dff565
Update docs/userGuide/syntax/includes.md
jingting1412 263eacd
Update docs/userGuide/syntax/includes.md
jingting1412 1df6f67
Update docs/userGuide/syntax/includes.md
jingting1412 2d9d4f4
Merge branch 'MarkBind:master' into popup-docs
jingting1412 262c987
Implement review changes
jingting1412 1693d54
Merge branch 'master' into popup-docs
Tim-Siu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep sure, I've put the example into a panel and changed the explanation to make it more clear! I think since this issue is about links breaking when being included with
<include>
, the note at the includes section in the UG and troubleshooting section is also just about this specific problem.If there's another cause to the link breaking issue other than
include
I think we can make a more generic one?