-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Tips and Tricks documentation for raw / endraw tags #2118
Conversation
Some suggestions:
👍
There's already the following mention in the math formulae part, you can move this warning into the tips and then include the tips back in the math section |
Thanks for the detailed suggestions @tlylt - I agree with all of them. I'll update accordingly! |
Updates in commit 76ac122:
Explanations for why this syntax could sometimes be an issue was added (with reference to the built-in Nunjucks support in MarkBind). Which specific cases for
The phrase on I've also included the section on Support for Nunjucks as a link instead (as part of the explanation) in Tips and Tricks - Using raw/endraw tags to display contents section, and modified the Math Formulae section according to the suggestion by @tlylt above. In addition, I think that it may be useful to include this also as a tip box within the Formatting Contents - Code section, as this syntax was an issue I encountered while converting the Vue.js documentation to MarkBind, and it was mostly the code blocks that had the |
I'm referring to exactly this one case of
Should be ok at the end of the section. |
Updates in commit 22379a3: I've added a more specific example of |
…hw-1/markbind into 1835-fenced-code-documentation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @lhw-1 for applying the changes, some more nits.
@lhw-1 pls remember to include the Proposed commit message in the future. |
What is the purpose of this pull request?
Overview of changes:
Updates the documentation for the
{% raw %}{% endraw %}
tags to be more reader friendly. This change is made in the Tips and Tricks - Using raw/endraw tags to display contents seciton.This issue was initially brought up in #762, which was resolved by the introduction of the raw / endraw tags in #1220. As this was already resolved, the issue #1835 was modified from a bug report to a documentation update. This PR hence resolves #1835 by addressing the suggestion to make the documentation for this feature more reader-friendly.
Anything you'd like to highlight/discuss:
While editing this part of the documentation, I initially wanted to use the code / output boilerplate like the ones currently being used in the Formatting Contents section, like such:
However, this seems to result in a compilation error with the following error message:
Meanwhile, this:
resulted in the following output on a test site:
As this is unrelated to the documentation update, it will be posted as a separate bug report. In any case, this is the reason why the code / output boilerplates were not used in this documentation update. (Any alternative suggestions would be great!)
Update: the issues #2119 and #2120 were opened to address these two bugs.
Apart from this, there are two more suggestions I would like input on, as they may / may not unnecessarily bloat the documentation:
Would it be helpful to include this section on Support for Nunjucks as a dropdown / content fragment in the Tips and Tricks - Using raw/endraw tags to display contents section?
Would it be helpful to include this Tips and Tricks - Using raw/endraw tags to display contents section as a dropdown / content fragment in the Math Formulae section, or any other relevant section?
Testing instructions:
Proposed commit message: (wrap lines at 72 characters)
Checklist: ☑️