Fix page & site nav component paddings #1564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Fixes #1562 (comment)
Follow up to #1403
Overview of changes:
.nav-component's (an "always there" layout element) padding is removed and shifted accordingly to the site and page nav.For the site nav, the corresponding negative margin simply shouldn't be there at all with the layouts system shift. (#1403)
For the page-nav, the padding is moved into the component instead (#1562 (comment))
Anything you'd like to highlight / discuss:
Testing instructions:
Proposed commit message: (wrap lines at 72 characters)
Fix page & site nav component paddings
Checklist: ☑️