-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix custom components markdown parsing #1548
Merged
ang-zeyu
merged 50 commits into
MarkBind:master
from
wxwxwxwx9:fix-custom-components-markdown-parsing
Apr 21, 2021
Merged
Changes from 21 commits
Commits
Show all changes
50 commits
Select commit
Hold shift + click to select a range
fc1127a
Initialize
wxwxwxwx9 3a8c23d
Remove comments
wxwxwxwx9 838d849
Fix regex rule
wxwxwxwx9 f676cc1
Update tests
wxwxwxwx9 ebaf948
Remove console log
wxwxwxwx9 b3bdd1f
Update comments
wxwxwxwx9 4f4e91d
Fix indentation in customComponentPlugin
wxwxwxwx9 da8e989
Update comment
wxwxwxwx9 32c83f3
Update "Pic" and "Thumbnail" components to inline
wxwxwxwx9 04a186e
Shift customComponent folder to patches
wxwxwxwx9 b08d586
Combine escape-special-tags into customComponent html block rule
wxwxwxwx9 1be94c9
Delete markdown-it-escape-special-tags.js
wxwxwxwx9 d5edc4e
Update tests
wxwxwxwx9 1f2340f
Tweak comments, indentations, and variable names
wxwxwxwx9 f0c2770
Correct variable name
wxwxwxwx9 80f6403
Remove script, pre, style from special tags
wxwxwxwx9 3740e1f
Revert "Update "Pic" and "Thumbnail" components to inline"
wxwxwxwx9 bec047a
Update tests
wxwxwxwx9 2cec817
Add pic and thumbnail as inline tags
wxwxwxwx9 a9ff6a4
Update test
wxwxwxwx9 948b5ce
Added script, pre, style back to special tags regex
wxwxwxwx9 6d3d213
Delete index file and shift source file link to customComponentPlugin
wxwxwxwx9 4105f69
Remove vueReservedTags
wxwxwxwx9 bde3a4c
Add popover, tooltip, trigger to inlineTags
wxwxwxwx9 81b65ec
Update tests
wxwxwxwx9 1bd4447
Update source file comments
wxwxwxwx9 2161fd0
Update minimizedPanelStringRegex to Zeyu's suggestion
wxwxwxwx9 116a3b5
Remove vueReservedTags file
wxwxwxwx9 858aff4
Update regex
wxwxwxwx9 5d35b63
Add test for panel minimized markdown parsing
wxwxwxwx9 c35741a
Update test comments
wxwxwxwx9 0566fb5
Update markdown-it-custom-component.test.js
wxwxwxwx9 8b63fc0
Update markdown-it-custom-component.test.js
wxwxwxwx9 0924d5c
Update markdown-it-custom-component.test.js
wxwxwxwx9 792df05
Update test description
wxwxwxwx9 29e7614
Add Zeyu's edge case
wxwxwxwx9 94986bc
Create testPanelMarkdownParsing.md
wxwxwxwx9 72a55b1
Update site.json
wxwxwxwx9 7996460
Update testPanelMarkdownParsing.md
wxwxwxwx9 613636c
Update tests
wxwxwxwx9 7c15fc3
Delete markdown-it-custom-component.test.js
wxwxwxwx9 8094748
Update NonFunctionalRequirements.md
wxwxwxwx9 5443c24
Update NonFunctionalRequirements._include_.html
wxwxwxwx9 6ae92ca
Update testPanelMarkdownParsing.md
wxwxwxwx9 0a66760
Update test
wxwxwxwx9 08541e4
Change seg to span
wxwxwxwx9 1802120
Update tests
wxwxwxwx9 a4e1095
Update all seg tag to span
wxwxwxwx9 5b74bca
Update seg to div
wxwxwxwx9 3fc4d98
Update tests
wxwxwxwx9 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
40 changes: 29 additions & 11 deletions
40
packages/cli/test/functional/test_site/expected/index.page-vue-render.js
Large diffs are not rendered by default.
Oops, something went wrong.
4 changes: 1 addition & 3 deletions
4
packages/cli/test/functional/test_site/expected/needsrenderedplugin._include_.html
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1 @@ | ||
<p> | ||
<panel><span slot="header" class="card-title"><b>header</b></span> Content of panel</panel> | ||
</p> | ||
<panel><span slot="header" class="card-title"><b>header</b></span> Content of panel</panel> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 changes: 4 additions & 6 deletions
10
...cli/test/functional/test_site/expected/requirements/SpecifyingRequirements._include_.html
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
...li/test/functional/test_site/expected/requirements/testBaseUrlInIncludeSrc._include_.html
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
<div>Requirements gathering, requirements elicitation, requirements analysis, | ||
requirements capture are some of the terms commonly <strong>and</strong> interchangeably used to represent the activity | ||
requirements capture are some of the terms commonly **and** interchangeably used to represent the activity | ||
of understanding what a software product should do.</div> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sounds good, over here might be better in fact since you've changed the behaviour of unknown tags