Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Whitelist <markdown> and <md> as special tags #1434

Merged
merged 1 commit into from
Dec 30, 2020

Conversation

ang-zeyu
Copy link
Contributor

What is the purpose of this pull request?

  • Documentation update
  • Bug fix
  • Feature addition or enhancement
  • Code maintenance
  • Others, please explain:

Final (hopefully) follow up to #1403 in preparation for markdown-htmlparser patch removal

Overview of changes:

  • Whitelist said tags as special tags, hence htmlparser parses its content as text for rendering later, allowing fancy markdown syntax inside
  • Add 'invalid html tests'
    • these are first tested with the htmlparser-markdown patch removed with expected failure, then the tags are whitelisted and retested. the htmlparser patch is also reintroduced, for removal in another pr

Anything you'd like to highlight / discuss:
na

Testing instructions:
na

Proposed commit message: (wrap lines at 72 characters)
Whitelist and as special tags


Checklist: ☑️

  • Updated the documentation for feature additions and enhancements
  • Added tests for bug fixes or features
  • Linked all related issues
  • No blatantly unrelated changes
  • Pinged someone for a review!

@ang-zeyu ang-zeyu force-pushed the md-markdown-special-tags branch from bc7de5b to 8f07e89 Compare December 30, 2020 12:06
@ang-zeyu ang-zeyu added this to the v3.0 milestone Dec 30, 2020
@ang-zeyu ang-zeyu merged commit a55bdca into MarkBind:master Dec 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant