Render markdown before finding hash content #1433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<include> elements referencing a specific #hash of a source file search for the hash before rendering the file's markdown. This prevents including elements with ids defined using markdown-it-attributes, and necessitates markdown-html patches. Let's process the included source file's markdown first, then search for the hash.
10 tasks
Closed
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Follow up to #1403, fixing one more instance where html is processed before markdown
Also fixes not being able to
<include src="xx#hash" />is#hashwas defined using markdown-it-attributes (e.g.**segment**{id="hash"})Overview of changes:
For
<include>s with hashes, shift the markdown rendering from post-hash-search to pre-hash-search.Anything you'd like to highlight / discuss:
<p>elements are unwrapped in the expected test sites; These occur because we are now retrieving the hash-content post-markdown-rendering of the included source fileTesting instructions:
na
Checklist: ☑️