Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc doc updates #1294

Merged
merged 9 commits into from
Jul 31, 2020
Merged

Misc doc updates #1294

merged 9 commits into from
Jul 31, 2020

Conversation

ang-zeyu
Copy link
Contributor

What is the purpose of this pull request? (put "X" next to an item, remove the rest)

• [x] Documentation update

What is the rationale for this request?
Resolve a couple more documentation issues before release

What changes did you make? (Give an overview)
810244d
#1274 (comment)

ac13f89
Resolves #1106 - review would be nice here, not sure if it's confusing @damithc
Should resolve #339 as well - <md> tags are already documented
Resolves #888
Resolves #1276

06e1907
Resolves #1258

2377dd4
Resolves #1151 - not too sure where to put this in the site nav, looks a little out of place 🤔

ae7a0bb
Resolves #611

3c5b75b
Resolves #1230

50c92a1
Resolves #993

Proposed commit message: (wrap lines at 72 characters)
Let's do a rebase merge here

Copy link
Contributor

@damithc damithc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work. Added a few comments.

</include>
</div>

<modal header="Richer formatting of attributes using slots" id="on-slots">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can use a large modal

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀 never knew this existed, it's undocumented as well. added a commit to document this too

--- {.border-danger}

Apply the same to inline markdown (eg. bold text) by
omitting the **space**{.text-primary .bg-light attribute=value}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

mistake?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

html attributes don't require the "quotes" if there aren't any spaces in the value

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't mean the quotes. That whole thing shouldn't be there, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's to show an example of attributes (vs classes and ids), but since these aren't visual, you'd have to use inspect element to see it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can use a real or real-looking attribute name and a value instead? Otherwise it looks like a generic placeholder.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added a comment to use inspect element

Apply the same to inline markdown (eg. bold text) by
omitting the **space**{.text-primary .bg-light attribute=value}
</variable>
</include>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Side question: what if I want to apply a style to multiple words inside a paragraph that doesn't have any markdown symbol around them? No shorthand syntax for that I guess.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep don't think there's any shorthand for that unfortunately

@@ -6,6 +6,7 @@
* [Setting up]({{baseUrl}}/devGuide/settingUp.html)
* [Workflow]({{baseUrl}}/devGuide/workflow.html)
* [Design]({{baseUrl}}/devGuide/design.html)
* [Writing Plugins]({{baseUrl}}/devGuide/writingPlugins.html)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Writing plugins is not just for devs. Even regular users are supposedly can write plugins. Give at least a link from the UG as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added. I think the main content should stay in the devguide though, since the large majority of users won't be writing such plugins.

ang-zeyu added 9 commits July 31, 2020 23:57
- Add section on markdown attributes (attributes.mbdf)
- Fix a minor spelling error in formattingContents.md
- Add missing newline at eof (images.mbdf, tables.mbdf)
- Add relative link example using markdown (links.mbdf)
- Add starting list number trick example (lists.mbdf)
@ang-zeyu ang-zeyu added this to the v2.15.0 milestone Jul 31, 2020
@ang-zeyu ang-zeyu merged commit 1643ccc into MarkBind:master Jul 31, 2020
@ang-zeyu
Copy link
Contributor Author

also:

Resolves #567

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment