-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify markdown-it parser variants #1056
Conversation
LGTM Unsure if we need to be concerned that authors can use markdown syntax that don't make sense in attributes though. |
I would think its better we leave that to the author's discretion, since its better to have things work where expected as far as markdown goes. Will update back if there are more changes other than rebasing on master |
7419bde
to
8334f40
Compare
Moved |
The markdown-it parser used for attributes in components uses a different set of plugins from the one used throughout markbind. Let's unify the two variants to reduce the potential amount of maintainence needed, and standardise the usable markdown syntax throughout markbind.
8334f40
to
b690ac0
Compare
* 'master' of https://github.com/MarkBind/markbind: Update test files (MarkBind#1138) Remove OK button from modals (MarkBind#1134) Add start from line number functionality to code blocks (MarkBind#1115) Allow special tags to be self-closing (MarkBind#1101) Simplify baseUrl resolving process (MarkBind#1087) Remove redundant file writing (MarkBind#1090) Bump acorn from 5.7.3 to 5.7.4 (MarkBind#1121) Bump acorn from 7.1.0 to 7.1.1 in /src/lib/markbind (MarkBind#1120) Unify markdown-it parser variants (MarkBind#1056) Remove dynamic include feature (MarkBind#1037) Fix flex shrink not applying in content wrapper (MarkBind#1135) Escape Nunjucks for special tags (MarkBind#1049) Update documentation on icon slot for boxes (MarkBind#1123)
…x-pageNav * 'master' of https://github.com/MarkBind/markbind: Update test files (MarkBind#1138) Remove OK button from modals (MarkBind#1134) Add start from line number functionality to code blocks (MarkBind#1115) Allow special tags to be self-closing (MarkBind#1101) Simplify baseUrl resolving process (MarkBind#1087) Remove redundant file writing (MarkBind#1090) Bump acorn from 5.7.3 to 5.7.4 (MarkBind#1121) Bump acorn from 7.1.0 to 7.1.1 in /src/lib/markbind (MarkBind#1120) Unify markdown-it parser variants (MarkBind#1056) Remove dynamic include feature (MarkBind#1037) Fix flex shrink not applying in content wrapper (MarkBind#1135) Escape Nunjucks for special tags (MarkBind#1049) Update documentation on icon slot for boxes (MarkBind#1123) Convert code in boxes to code block (MarkBind#1086)
The markdown-it parser used for attributes in components uses a different set of plugins from the one used throughout markbind. Let's unify the two variants to reduce the potential amount of maintainence needed, and standardise the usable markdown syntax throughout markbind.
What is the purpose of this pull request? (put "X" next to an item, remove the rest)
• [x] Documentation update
• [x] Other, please explain:
As mentioned here: #975 (comment)
What is the rationale for this request?
To standardise the two parser variants used for attributes in components and all other cases,
which should reduce the potential matainence needed, and standardises the feature set
across the two locations.
As a result:
Two markdown-it plugins vue-strap has but MarkBind dosen't were added:
~...~
)^...^
)Three markdown-it plugins MarkBind has but vue-strap dosen't were added to vue attributes:
{ ... }
)[^footnoteidentifier] or ^[inline footnote]
)Markdown-it plugins MarkBind has but vue-strap dosen't, but would not be used in attributes anyway, and dosen't conflict with existing syntax:
[[toc]]
)1./*/- [x]
)@[youtube](lJIrF4YjHfQ)
)- ( ) Item 1
)What changes did you make? (Give an overview)
Is there anything you'd like reviewers to focus on?
na
Testing instructions:
npm run test
should passbuild
on the 2103 site should have no diffs, save for timestamps and logsProposed commit message: (wrap lines at 72 characters)
Unify markdown-it parser variants
The markdown-it parser used for attributes in components
uses a different set of plugins from the one used throughout markbind.
Let's unify the two variants to reduce the potential amount of
maintainence needed, and standardise the usable markdown
syntax throughout markbind.