Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconsider the need for the lower, white navbar #2093

Open
ang-zeyu opened this issue Jan 15, 2023 · 2 comments
Open

Reconsider the need for the lower, white navbar #2093

ang-zeyu opened this issue Jan 15, 2023 · 2 comments

Comments

@ang-zeyu
Copy link
Contributor

Please confirm that you have searched existing issues in the repo

Yes, I have searched the existing issues

Any related issues?

Removes need for some of #1948

What is the area that this feature belongs to?

No response

Is your feature request related to a problem? Please describe.

The design lower navbar section containing the site and page nav buttons has some issues:

  • While we have auto hide/show features for the header, the navbar does still take up some amount of space.
  • There was some talk of FOUC coming from the lower section in the mobile header but I can't find that issue now. But that is another reason. FOUC happens due to performing style detection of whether we should show/hide the lower navbar based on the screen size.

Describe the solution you'd like

Some basic ideas for reference:

  • FABs
  • Reorganize the navbar to, somehow, contain all of (1) logo (2) nav items (3) search (4) site nav button (5) page nav button in mobile view.

First come up with a design, get input on it, then implement it.

Describe alternatives you've considered

No response

Additional context

No response

@ang-zeyu
Copy link
Contributor Author

@jonahtanjz if you have any input

@jonahtanjz
Copy link
Contributor

First come up with a design, get input on it, then implement it.

Some possible designs that we can consider - #980 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants