Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Component-ify the back-to-top button #2081

Closed
ang-zeyu opened this issue Jan 15, 2023 · 0 comments · Fixed by #2170
Closed

Component-ify the back-to-top button #2081

ang-zeyu opened this issue Jan 15, 2023 · 0 comments · Fixed by #2170
Assignees
Labels
a-CodeQuality breakingChange 💥 Feature will behave significantly different, or is made obsolete d.easy p.Low

Comments

@ang-zeyu
Copy link
Contributor

Please confirm that you have searched existing issues in the repo

Yes, I have searched the existing issues

Any related issues?

No response

What is the area that this feature belongs to?

No response

Is your feature request related to a problem? Please describe.

The back to top button is a mandatory (iirc..) and "in built" feature in the page build process. The logic is contained within a javascript file.

Describe the solution you'd like

Consider making this optional, and component-ifying it instead.

The feature would be opt in by placing this component in a layout file.

Describe alternatives you've considered

No response

Additional context

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a-CodeQuality breakingChange 💥 Feature will behave significantly different, or is made obsolete d.easy p.Low
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants