Prevent plugins from modifying the page config

MarkBind · Mar 18, 2019 · f919f03 · f919f03
1 parent 7c8dfbb
commit f919f03
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 5 deletions.
diff --git a/src/Page.js b/src/Page.js
@@ -65,7 +65,6 @@ function Page(pageConfig) {
   this.layoutsAssetPath = pageConfig.layoutsAssetPath;
   this.rootPath = pageConfig.rootPath;
   this.enableSearch = pageConfig.enableSearch;
-  this.pageConfig = pageConfig;
   this.plugins = pageConfig.plugins;
   this.pluginsContext = pageConfig.pluginsContext;
   this.searchable = pageConfig.searchable;
@@ -803,11 +802,13 @@ Page.prototype.generate = function (builtFiles) {
  */
 Page.prototype.preRender = function (content) {
   let preRenderedContent = content;
+  const pageConfig = {
+  };
   Object.entries(this.plugins).forEach(([pluginName, plugin]) => {
     if (plugin.preRender) {
       preRenderedContent
         = plugin.preRender(preRenderedContent, this.pluginsContext[pluginName] || {},
-                           this.frontMatter, this.pageConfig);
+                           this.frontMatter, pageConfig);
     }
   });
   return preRenderedContent;
@@ -818,11 +819,14 @@ Page.prototype.preRender = function (content) {
  */
 Page.prototype.postRender = function (content) {
   let postRenderedContent = content;
+  const pageConfig = {
+    headingIndexingLevel: this.headingIndexingLevel,
+  };
   Object.entries(this.plugins).forEach(([pluginName, plugin]) => {
     if (plugin.postRender) {
       postRenderedContent
         = plugin.postRender(postRenderedContent, this.pluginsContext[pluginName] || {},
-                            this.frontMatter, this.pageConfig);
+                            this.frontMatter, pageConfig);
     }
   });
   return postRenderedContent;

diff --git a/src/Site.js b/src/Site.js
@@ -697,8 +697,7 @@ function findDefaultPlugins() {
   return walkSync(globPath, {
     directories: false,
     globs: [`${MARKBIND_PLUGIN_PREFIX}*.js`],
-  })
-    .map(file => path.parse(file).name);
+  }).map(file => path.parse(file).name);
 }
 
 /**