Fix: Uncaught exceptions cause a silent exit (#721)

MarkBind · Feb 25, 2019 · a91b2de · a91b2de
1 parent 14b8a5c
commit a91b2de
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 7 deletions.
diff --git a/src/lib/markbind/src/parser.js b/src/lib/markbind/src/parser.js
@@ -276,7 +276,8 @@ Parser.prototype._preprocess = function (node, context, config) {
 
     // Render inner file content
     fileContent = nunjucks.renderString(fileContent,
-                                        { ...pageVariables, ...includeVariables, ...userDefinedVariables });
+                                        { ...pageVariables, ...includeVariables, ...userDefinedVariables },
+                                        { path: actualFilePath });
 
     // Delete variable attributes in include
     Object.keys(element.attribs).forEach((attribute) => {
@@ -504,7 +505,9 @@ Parser.prototype.includeFile = function (file, config) {
       const { parent, relative } = calculateNewBaseUrls(file, config.rootPath, config.baseUrlMap);
       const userDefinedVariables = config.userDefinedVariablesMap[path.resolve(parent, relative)];
       const pageVariables = extractPageVariables(path.basename(file), data, userDefinedVariables, {});
-      const fileContent = nunjucks.renderString(data, { ...pageVariables, ...userDefinedVariables });
+      const fileContent = nunjucks.renderString(data,
+                                                { ...pageVariables, ...userDefinedVariables },
+                                                { path: actualFilePath });
       const fileExt = utils.getExt(file);
       if (utils.isMarkdownFileExt(fileExt)) {
         context.source = 'md';
@@ -658,7 +661,7 @@ Parser.prototype._rebaseReference = function (node, foundBase) {
               // and let the hostBaseUrl value be injected later.
               hostBaseUrl: '{{hostBaseUrl}}',
               baseUrl: newBaseUrl,
-            });
+            }, { path: filePath });
             element.children = cheerio.parseHTML(rendered, true);
             cheerio.prototype.options.xmlMode = true;
           }
@@ -694,7 +697,7 @@ Parser.prototype._rebaseReferenceForStaticIncludes = function (pageData, element
 
   const newBase = fileBase.relative;
   const newBaseUrl = `{{hostBaseUrl}}/${newBase}`;
-  return nunjucks.renderString(pageData, { baseUrl: newBaseUrl });
+  return nunjucks.renderString(pageData, { baseUrl: newBaseUrl }, { path: filePath });
 };
 
 module.exports = Parser;
diff --git a/src/util/logger.js b/src/util/logger.js
@@ -8,6 +8,13 @@ const DailyRotateFile = require('winston-daily-rotate-file');
 winston.configure({
   exitOnError: false,
   transports: [
+    new (winston.transports.Console)({
+      colorize: true,
+      handleExceptions: true,
+      humanReadableUnhandledException: true,
+      level: 'info',
+      showLevel: true,
+    }),
     new DailyRotateFile({
       datePattern: 'YYYY-MM-DD',
       dirname: '_markbind/logs',
@@ -23,15 +30,12 @@ winston.configure({
 
 module.exports = {
   error: (text) => {
-    console.log(chalk.red(`error: ${text}`));
     winston.error(text);
   },
   warn: (text) => {
-    console.log(chalk.yellow(`warning: ${text}`));
     winston.warn(text);
   },
   info: (text) => {
-    console.log(chalk.cyan('info: ') + text);
     winston.info(text);
   },
   verbose: (text) => {