MDBF-994: MTR Generator to unify mtr invocation in Buildbot #722
+322
−64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d67e0e8 to
a3e7357
Compare
This is in preparation for sharing code for MTRGenerator
de1962a to
cec6f98
Compare
This class creates typesafety much like CMake Generator and allows us to ensure we run all MTR commands in the same format, with parameters sorted. Typos also cause immediate script validation failure, rather than a failure at runtime.
|
@RazvanLiviuVarzaru The pre-commit failures are actually false positives. Unit tests pass so imports are ok. The assertIn suggestion is incorrect as it's suggesting that I change a function name. |
Easy to fix (please do), see https://github.com/MariaDB/buildbot/blob/dev/.codespellrc. Also, if E0402 is wrong, we should disable it, either everywhere or only in that file. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces an MTR Generator so we can standardise MTR invocation. It's likely not in its final form, we will likely have to add ENVIRONMENT variables support, for MTR_FEEDBACK_PLUGIN=1 for instance, but this will happen when we have specific builders use this class. For now the code is not used in any buildbot config, although it does have unit tests.
Refactoring:
Extract the base common logic from CMakeGenerator and put it into the "base" folder instead.