-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Addressing issue #65 - Expanded evaluator class: extract results as a Dataframe #80
Conversation
…d dictionary as a dataframe
Write a more detailed description, refer to what issue this solves and include instructions on how the reviewer can test that its working. those instructions can form the basis of a test that is lacking as well. |
This pull request addresses issue #65 (comment), which involved extracting the results from the Evaluator class as a pandas DataFrame. Changes made: Added Method: Introduced a new method results_to_dataframe in the Evaluator class. Transposed the nested dictionary from the Evaluator class. |
Much better - this can now go into the PR description |
Hi @adgianv , thanks for your contribution. Please, rename the PR title to a sentence summarizing what you are proposing. Can you also add a test for the new method you are introducing? |
Changes made: Added Method: Introduced a new method results_to_dataframe in the Evaluator class. Summary of Changes: These changes improve the usability of the evaluation results by providing a straightforward way to view and analyse them in a tabular format. |
With this new commit I modified the results_to_dataframe method to allow for more complicated nested structures in the results. To do it I added a helper method in the Evaluator class called _flatten_dict, that flattens a nested dataframe. I added a relevant test in the test_evaluator.py file called test_results_to_dataframe. |
You just need to address the following two comments
and
also tests need to pass in CI |
this PR also introduces pandas as a dependency |
I added it in the description |
sorry, I meant you need to add it to the |
seems all good now! 🚀 thanks for your effort and contribution! I will approved it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@nsorros @ivyleavedtoadflax after this merge I would bump the version, add the release notes (how is that actually added?) - and then we can make a new release - wdyt? |
This pull request addresses issue #65 (comment), which involved extracting the results from the Evaluator class as a pandas DataFrame.
Changes made:
Added Method: Introduced a new method results_to_dataframe in the Evaluator class.
Functionality: This method transposes the nested dictionary of evaluation results and converts it into a pandas DataFrame. This transformation makes the results more readable and easier to analyse.
Summary of Changes:
These changes improve the usability of the evaluation results by providing a straightforward way to view and analyse them in a tabular format.