-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[manta] Dolphin V2 runtime #371
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dziabko left a few todos that would be nice, but feel free to implement them in a separate PR, as this one might get too big. If you go that route, please log them.
Also provide a more detailed description as to what is the difference with Calamari. More importantly why we're doing this.
…voting, launching, enactment, cooloff periods.
…ziabko/add-dolphin-runtime
@dziabko Can you investigate why CI fails? |
The unit test still fails. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just the couple of comment and new line request. Otherwise looks ready.
@Dengjianping Can you review whether your concerns have been fixed? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
231e635
to
a166b46
Compare
Signed-off-by: Daniel Ziabko <daniel399ziabko@gmail.com>
a166b46
to
25dd133
Compare
Description
Added dolphin runtime to manta branch.
closes: #349
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
manta
ordolphin
) with right title (start with [Manta] or [Dolphin]),Files changed
in the Github PR explorer.authoring_version
: The version of the authorship interface. An authoring node will not attempt to author blocks unless this is equal to its native runtime.spec_version
: The version of the runtime specification. A full node will not attempt to use its native runtime in substitute for the on-chain Wasm runtime unless all of spec_name, spec_version, and authoring_version are the same between Wasm and native.impl_version
: The version of the implementation of the specification. Nodes are free to ignore this; it serves only as an indication that the code is different; as long as the other two versions are the same then while the actual code may be different, it is nonetheless required to do the same thing. Non-consensus-breaking optimizations are about the only changes that could be made which would result in only the impl_version changing.transaction_version
: The version of the extrinsics interface. This number must be updated in the following circumstances: extrinsic parameters (number, order, or types) have been changed; extrinsics or pallets have been removed; or the pallet order in the construct_runtime! macro or extrinsic order in a pallet has been changed. If this number is updated, then the spec_version must also be updatedversion
for every crate.BaseFilter
. Ensure every extrinsic works from front-end. If there's corresponding tool, ensure both work for each other.