Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[manta] Dolphin V2 runtime #371

Closed
wants to merge 14 commits into from
Closed

Conversation

dziabko
Copy link
Contributor

@dziabko dziabko commented Jan 29, 2022

Description

Added dolphin runtime to manta branch.

closes: #349


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (manta or dolphin) with right title (start with [Manta] or [Dolphin]),
  • Linked to Github issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Wrote unit tests.
  • Updated relevant documentation in the code.
  • Re-reviewed Files changed in the Github PR explorer.
  • If runtime changes, need to update the version numbers properly:
    • authoring_version: The version of the authorship interface. An authoring node will not attempt to author blocks unless this is equal to its native runtime.
    • spec_version: The version of the runtime specification. A full node will not attempt to use its native runtime in substitute for the on-chain Wasm runtime unless all of spec_name, spec_version, and authoring_version are the same between Wasm and native.
    • impl_version: The version of the implementation of the specification. Nodes are free to ignore this; it serves only as an indication that the code is different; as long as the other two versions are the same then while the actual code may be different, it is nonetheless required to do the same thing. Non-consensus-breaking optimizations are about the only changes that could be made which would result in only the impl_version changing.
    • transaction_version: The version of the extrinsics interface. This number must be updated in the following circumstances: extrinsic parameters (number, order, or types) have been changed; extrinsics or pallets have been removed; or the pallet order in the construct_runtime! macro or extrinsic order in a pallet has been changed. If this number is updated, then the spec_version must also be updated
  • If needed, notify the committer this is a draft-release and a tag is needed after merging the PR.
  • Verify benchmarks & weights have been updated for any modified runtime logics
  • If needed, bump version for every crate.
  • If import a new pallet, choose a proper module index for it, and allow it in BaseFilter. Ensure every extrinsic works from front-end. If there's corresponding tool, ensure both work for each other.
  • If needed, update our Javascript/Typescript APIs. These APIs are offcially used by exchanges or community developers.
  • If we're going to issue a new release, freeze the code one week early(it depends, but usually it's one week), ensure we have enough time for related testing.

@dziabko dziabko requested review from stechu and ghzlatarev January 29, 2022 01:38
@dziabko dziabko self-assigned this Jan 29, 2022
Copy link
Contributor

@ghzlatarev ghzlatarev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dziabko left a few todos that would be nice, but feel free to implement them in a separate PR, as this one might get too big. If you go that route, please log them.
Also provide a more detailed description as to what is the difference with Calamari. More importantly why we're doing this.

runtime/dolphin/src/fee.rs Outdated Show resolved Hide resolved
runtime/dolphin/src/impls.rs Show resolved Hide resolved
runtime/dolphin/src/lib.rs Outdated Show resolved Hide resolved
runtime/dolphin/src/lib.rs Outdated Show resolved Hide resolved
runtime/dolphin/src/lib.rs Outdated Show resolved Hide resolved
runtime/dolphin/src/lib.rs Show resolved Hide resolved
node/src/chain_specs/dolphin.rs Outdated Show resolved Hide resolved
runtime/dolphin/src/weights/frame_system.rs Show resolved Hide resolved
runtime/dolphin/src/lib.rs Outdated Show resolved Hide resolved
runtime/dolphin/src/lib.rs Outdated Show resolved Hide resolved
@dziabko dziabko requested a review from Dengjianping February 1, 2022 01:09
@stechu
Copy link
Collaborator

stechu commented Feb 3, 2022

@dziabko Can you investigate why CI fails?

runtime/dolphin/src/lib.rs Show resolved Hide resolved
@stechu stechu mentioned this pull request Feb 3, 2022
12 tasks
@stechu
Copy link
Collaborator

stechu commented Feb 6, 2022

The unit test still fails.

runtime/dolphin/Cargo.toml Outdated Show resolved Hide resolved
Copy link
Contributor

@ghzlatarev ghzlatarev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the couple of comment and new line request. Otherwise looks ready.

@dziabko dziabko requested a review from stechu February 7, 2022 19:15
@stechu
Copy link
Collaborator

stechu commented Feb 8, 2022

@Dengjianping Can you review whether your concerns have been fixed?

@Dengjianping
Copy link
Contributor

Dengjianping commented Feb 8, 2022

I have two questions here:

  1. Do we reuse the session keys/sudo key/invulnerable keys from calamari testnet?
  2. The icon doesn't show correctly in the frontend.

Screen Shot 2022-02-08 at 12 43 24 PM

If this pr is really urgent, I think we can fix them by another pr. For the icon issue, perhaps we have to submit a pr to polkadot-js.

@dziabko dziabko requested a review from Dengjianping February 8, 2022 15:57
Copy link
Contributor

@Dengjianping Dengjianping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dziabko dziabko force-pushed the dziabko/add-dolphin-runtime branch 2 times, most recently from 231e635 to a166b46 Compare February 9, 2022 17:51
Signed-off-by: Daniel Ziabko <daniel399ziabko@gmail.com>
@dziabko dziabko force-pushed the dziabko/add-dolphin-runtime branch from a166b46 to 25dd133 Compare February 9, 2022 17:52
@stechu stechu closed this Feb 9, 2022
@ghzlatarev ghzlatarev deleted the dziabko/add-dolphin-runtime branch March 9, 2022 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dolphin V2 Runtime
4 participants