-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Manta-PC] Updrading dependencies to v0.9.10
#195
Conversation
@stechu reverted the |
@stechu triggered the integration tests with a fake tag name |
I am not sure whether this alone will do that job. In the code, you still rely on the new version of XCM. I would suggest you to roll-back the XCM related code, i.e. still use |
@ghzlatarev As we discussed, can you provide the list of upstream changes that we can review against to? |
My bad included it in the description. |
I don't seem to be able to make the runtime code compile without using |
@stechu Do you think we need to bump the version as well? From |
We should. |
|
@ghzlatarev Here is an example of how to properly description a upstream upgrade: Polkadot Changes: The list of polkadot changes
Overview PR: Please do the same for Cumulus and Substrate. |
Substrate Changes:
Cumulus Changes:
|
Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description
closes: #196
Polkadot Changes:
Overview PR:
Substrate Changes:
Cumulus Changes:
statemine
diffs between:fd80849dde5c209c20a996cfcc5aaacd4666dcbe
->0.9.9
fa116cfbfb470a8114fc02f9d2e3c0a5ab6c7193
->0.9.10
Performed tests with local
calamari-local
andcalamari-testnet
networks:system.setCode
upgradeauthorizeUpgrade + enactAuthorized
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
manta
ormanta-pc
) with right title (start with [Manta] or [Manta-PC]),Files changed
in the Github PR explorer.authoring_version
: The version of the authorship interface. An authoring node will not attempt to author blocks unless this is equal to its native runtime.spec_version
: The version of the runtime specification. A full node will not attempt to use its native runtime in substitute for the on-chain Wasm runtime unless all of spec_name, spec_version, and authoring_version are the same between Wasm and native.impl_version
: The version of the implementation of the specification. Nodes are free to ignore this; it serves only as an indication that the code is different; as long as the other two versions are the same then while the actual code may be different, it is nonetheless required to do the same thing. Non-consensus-breaking optimizations are about the only changes that could be made which would result in only the impl_version changing.transaction_version
: The version of the extrinsics interface. This number must be updated in the following circumstances: extrinsic parameters (number, order, or types) have been changed; extrinsics or pallets have been removed; or the pallet order in the construct_runtime! macro or extrinsic order in a pallet has been changed. If this number is updated, then the spec_version must also be updated