Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix benchmark #1253

Merged
merged 6 commits into from
Sep 9, 2023
Merged

Fix benchmark #1253

merged 6 commits into from
Sep 9, 2023

Conversation

anaye1997
Copy link
Contributor

@anaye1997 anaye1997 commented Sep 8, 2023

Description


Before we can approve this PR for merge, please make sure that all the following items have been checked off:

  • Connected to an issue with discussion and accepted design using zenhub "Connect issue" button below
  • Added one label out of the L- group to this PR
  • Added one or more labels from the A- and C- groups to this PR
  • Explicitly labelled A-calamari and/or A-manta if your changes are meant for/impact either of these (CI depends on it)
  • Re-reviewed Files changed in the Github PR explorer.
  • Add A-integration-test-checks to run start-integration-test-checks (Required)
  • Add A-benchmark-checks to run start-benchmark-check (Required)
  • Add A-unit-test-checks to run start-unit-test-checks (Required)
  • Add A-congestion-test-checks to run start-integration-test-checks (Optional)

Situational Notes:

  • If adding functionality, write unit tests!
  • If importing a new pallet, choose a proper module index for it, and allow it in BaseFilter. Ensure every extrinsic works from front-end. If there's corresponding tool, ensure both work for each other.
  • If needed, update our Javascript/Typescript APIs. These APIs are officially used by exchanges or community developers.
  • If modifying existing runtime storage items, make sure to implement storage migrations for the runtime and test them with try-runtime. This includes migrations inherited from upstream changes, and you can search the diffs for modifications of #[pallet::storage] items to check for any.

Dengjianping and others added 3 commits September 7, 2023 12:22
Signed-off-by: Dengjianping <djptux@gmail.com>
Signed-off-by: Dengjianping <djptux@gmail.com>
Signed-off-by: Anathan (Ana) Ye <anaye@duck.com>
@anaye1997 anaye1997 requested a review from a team as a code owner September 8, 2023 03:10
Signed-off-by: Dengjianping <djptux@gmail.com>
Signed-off-by: Dengjianping <djptux@gmail.com>
Signed-off-by: Dengjianping <djptux@gmail.com>
@Dengjianping Dengjianping added the L-fixed Log: Issues and PRs related to bug fixes label Sep 8, 2023
Copy link
Contributor

@ferrell-code ferrell-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note benchmarks need correct hardware requirements https://wiki.polkadot.network/docs/maintain-guides-how-to-validate-polkadot#standard-hardware.

A too powerful machine would cause too fast benchmarks. I think this lines up with the hardware used, but want to make sure

@anaye1997 anaye1997 merged commit eb48ca1 into manta Sep 9, 2023
@anaye1997 anaye1997 deleted the fix-benchmark branch September 9, 2023 10:47
@Dengjianping
Copy link
Contributor

@anaye1997 can you post the configuration of this machine?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-benchmark-checks A-calamari Area: Issues and PRs related to the Calamari Runtime A-integration-test-checks A-unit-test-checks L-fixed Log: Issues and PRs related to bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants