Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rebenchmark mantaSbt #1192

Merged
merged 13 commits into from
Aug 28, 2023
Merged

Rebenchmark mantaSbt #1192

merged 13 commits into from
Aug 28, 2023

Conversation

Dengjianping
Copy link
Contributor

@Dengjianping Dengjianping commented Jul 9, 2023 •
edited
Loading

Description

Closed #1151

Before we can approve this PR for merge, please make sure that all the following items have been checked off:

  • Connected to an issue with discussion and accepted design using zenhub "Connect issue" button below
  • Added one label out of the L- group to this PR
  • Added one or more labels from the A- and C- groups to this PR
  • Explicitly labelled A-calamari and/or A-manta if your changes are meant for/impact either of these (CI depends on it)
  • Re-reviewed Files changed in the Github PR explorer.

Situational Notes:

  • If adding functionality, write unit tests!
  • If importing a new pallet, choose a proper module index for it, and allow it in BaseFilter. Ensure every extrinsic works from front-end. If there's corresponding tool, ensure both work for each other.
  • If needed, update our Javascript/Typescript APIs. These APIs are officially used by exchanges or community developers.
  • If modifying existing runtime storage items, make sure to implement storage migrations for the runtime and test them with try-runtime. This includes migrations inherited from upstream changes, and you can search the diffs for modifications of #[pallet::storage] items to check for any.

@Dengjianping
[no ci]Add a script to send to_private coins to mantasbt, and generat…
762fe88 
…e coins by multi-threading

Signed-off-by: Dengjianping <djptux@gmail.com>
@Dengjianping Dengjianping added C-enhancement Category: An issue proposing an enhancement or a PR with one A-weights Area: Issues and PRs related to Substrate Weights A-manta Area: Issues and PRs related to the Manta Runtime A-calamari Area: Issues and PRs related to the Calamari Runtime A-manta-pay Area: Issues and PRs related to the MantaPay Pallet L-changed Log: Issues and PRs related to changes labels Jul 9, 2023
@Dengjianping Dengjianping self-assigned this Jul 9, 2023
@Dengjianping
[no ci]Update sbt mint script
11a0d6a 
Signed-off-by: Dengjianping <djptux@gmail.com>
@Dengjianping Dengjianping marked this pull request as ready for review July 17, 2023 01:58
@github-actions
Copy link

github-actions bot commented Jul 17, 2023 •
edited
Loading

⚠️ Congestion test: 1-day congestion cost (calamari-runtime) is NOT above the target daily congestion cost

@github-actions
Copy link

github-actions bot commented Jul 17, 2023 •
edited
Loading

✅ Congestion test: 1-day congestion cost (manta-runtime) is above the target daily congestion cost

@Dengjianping
Merge branch 'manta' into rebenchmark-mantasbt
0a36863
@Dengjianping
[no ci]Add mantasbt mints file and update append_storage script
7de193a 
Signed-off-by: Dengjianping <djptux@gmail.com>
@Dengjianping
Remove precompute coins file
8ae8e69 
Signed-off-by: Dengjianping <djptux@gmail.com>
@Dengjianping
Fix mantasbt benchmark tests
6d6c143 
Signed-off-by: Dengjianping <djptux@gmail.com>
@Dengjianping
According cpu cores to decide how many coins in one thread
6209468 
Signed-off-by: Dengjianping <djptux@gmail.com>
@ghzlatarev ghzlatarev requested a review from a team as a code owner August 22, 2023 13:07
ghzlatarev
ghzlatarev reviewed Aug 24, 2023
View reviewed changes
Copy link
Contributor

@ghzlatarev ghzlatarev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good, I wonder what the weights results will be

tests/mantaSbt_toprivate.js Outdated Show resolved Hide resolved
@Dengjianping
Fix ci and resolve clippy warnings
de80ce5 
Signed-off-by: Dengjianping <djptux@gmail.com>
@Dengjianping
Fix clippy
6633afd 
Signed-off-by: Dengjianping <djptux@gmail.com>
ferrell-code
ferrell-code approved these changes Aug 25, 2023
View reviewed changes
Copy link
Contributor

@ferrell-code ferrell-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

tests/append_storage.js Show resolved Hide resolved
@ghzlatarev ghzlatarev merged commit 5fe54c8 into manta Aug 28, 2023
@ghzlatarev ghzlatarev deleted the rebenchmark-mantasbt branch August 28, 2023 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghzlatarev ghzlatarev ghzlatarev approved these changes

@ferrell-code ferrell-code ferrell-code approved these changes

@anaye1997 anaye1997 anaye1997 approved these changes

@zqhxuyuan zqhxuyuan Awaiting requested review from zqhxuyuan

Assignees

@Dengjianping Dengjianping

Labels
A-benchmark-checks A-calamari Area: Issues and PRs related to the Calamari Runtime A-integration-test-checks A-manta Area: Issues and PRs related to the Manta Runtime A-manta-pay Area: Issues and PRs related to the MantaPay Pallet A-unit-test-checks A-weights Area: Issues and PRs related to Substrate Weights C-enhancement Category: An issue proposing an enhancement or a PR with one L-changed Log: Issues and PRs related to changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rebenchmark pallet mantaSbt
4 participants
@Dengjianping @ghzlatarev @ferrell-code @anaye1997