-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HS2] Fixed bug with incorrect character card paths #52
[HS2] Fixed bug with incorrect character card paths #52
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What happens when there are cards with the same file name in 2 subfolders?
It is overwritten by the last registered card. Maybe a very large patch to the game's code to stop the recycling of ChaFile, or recording the full path instead of the file name, might help, but the effort would be tremendous. Considering what went wrong, it was a bad idea to allow the existence of a file with the same name, ignoring the specification on the game itself that only the file name is used for management. |
Note: The reason why charaFileName and path are different from the actual state of ChaFile is that they are set to values that were stored elsewhere immediately before the function was called.
|
#51 GetSourceFilePath() uses Dictionary<ChaFile, string> to map a file path to a ChaFile, and was not working as expected when the ChaFile was recycled.
Please review and merge.