Make the actual read happen in UB tests #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5b6d452 to
b5b1b05
Compare
Manishearth
commented
Oct 14, 2024
| @@ -909,7 +909,7 @@ mod tests { | |||
| uninit.as_mut_slice()[0].write(String::from("nonononono")); | |||
|
|
|||
| // Read invalidated reference to trigger UB | |||
| let _ = *x; | |||
| let _read = &*x; | |||
There was a problem hiding this comment.
@GnomedDev x here is unsized, which is why the & was necessary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
let _ = ...is a wildcard binding and as such may not perform a read (I'm not 100% sure on the internal semantics here, but using an actual binding avoids the question)