Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose the wildcard validation variable #5

Merged
merged 1 commit into from
Feb 22, 2022
Merged

Conversation

qannard
Copy link
Contributor

@qannard qannard commented Feb 14, 2022

Hello Garland,

We have a use case where we need to expose the underlying wildcard functionality from the module you are using. As it was quite trivial to amend your code, I would like to propose a PR to manage this. Looking forward to your feedback!

Best regards,
Annard
senior backend developer, Qstream Inc

The underlying module allows wildcard patters
to match for validations and this simple patch allows
this to be passed on.
Updated documentation.
Minor formatting adjustments from `terraform fmt`.
@sekka1
Copy link
Contributor

sekka1 commented Feb 22, 2022

Hi @qannard .... Cool! Thanks for the addition. This looks reasonable to me. Merging and tagging a release for this!

Let me know if you need anything else! =)

@sekka1 sekka1 merged commit 4ada6e5 into ManagedKube:main Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants