Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add specs js test for Middleware Topology Controller for Issue #8214 #8642

Merged
merged 1 commit into from
May 12, 2016
Merged

Add specs js test for Middleware Topology Controller for Issue #8214 #8642

merged 1 commit into from
May 12, 2016

Conversation

mtho11
Copy link
Contributor

@mtho11 mtho11 commented May 11, 2016

Add javascript spec test coverage for middleware topology controller.

Had to make visibility changes to MiddlewareTopologyCtrl.class_name and getDimensions so that they would be visible to Jasmine.

@mtho11
Copy link
Contributor Author

mtho11 commented May 11, 2016

@abonas please review

@miq-bot
Copy link
Member

miq-bot commented May 11, 2016

Checked commit mtho11@f48dce2 with ruby 2.2.3, rubocop 0.37.2, and haml-lint 0.16.1
0 files checked, 0 offenses detected
Everything looks good. 👍

@mtho11 mtho11 mentioned this pull request May 12, 2016
Closed
@abonas
Copy link
Member

abonas commented May 12, 2016

@miq-bot add_label test, ui, providers/hawkular, topology

@abonas
Copy link
Member

abonas commented May 12, 2016

LGTM
@himdel @martinpovolny pls review.

@abonas
Copy link
Member

abonas commented May 12, 2016

@mtho11 in order to link and automatically close the issue via this commit when it's merged, pls update the commit message with the relevant keyword and issue number, as explained here:
https://help.github.com/articles/closing-issues-via-commit-messages/
thanks!

@martinpovolny martinpovolny added this to the Sprint 41 Ending May 30, 2016 milestone May 12, 2016
@martinpovolny martinpovolny merged commit 7ec5a47 into ManageIQ:master May 12, 2016
@himdel
Copy link
Contributor

himdel commented May 12, 2016 •
edited
Loading

@mtho11 could you please change the newly added spec to use 2 spaces for indent instead of 4? For consistency...

Otherwise, looks good :)

EDIT: aah, I'm late to the party I see.. never mind then :)

@martinpovolny
Copy link
Member

@mtho11 : please, fix the indent in a separate PR. Thx!

@mtho11 mtho11 deleted the mtho11/middleware_topology_js_controller_tests branch May 12, 2016 14:34
@mtho11 mtho11 mentioned this pull request May 12, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@martinpovolny martinpovolny

Labels
providers/middleware providers/topology test ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@mtho11 @miq-bot @abonas @himdel @martinpovolny @Fryguy @chessbyte