SIGKILL can't be trapped, so don't try #2313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The SIGKILL signal [cannot be trapped or ignored](http://en.wikipedia.org/wiki/Unix_signal#SIGKILL), so we shouldn't try. Newer versions of Ruby will raise an exception if you try to trap this signal.
|
Checked commit tenderlove@0c5d607 with rubocop 0.27.1 vmdb/lib/workers/worker_base.rb
|
|
👍 |
jrafanie
added a commit
that referenced
this pull request
Mar 23, 2015
SIGKILL can't be trapped, so don't try
jrafanie
added a commit
to jrafanie/manageiq
that referenced
this pull request
Mar 27, 2015
jrafanie
added a commit
to jrafanie/manageiq
that referenced
this pull request
Jun 25, 2015
Fixes `appliance_console.rb:105 in `trap': invalid argument - SIGKILL` Ruby 2.1 and earlier lets you trap SIGKILL even though it's useless. Ruby 2.2 won't let you try to trap it. See ManageIQ#2313 [skip ci]
simaishi
pushed a commit
that referenced
this pull request
Oct 9, 2017
…ialog_field_types Allow required flag to be set/unset for all dialog field types (cherry picked from commit f40bb3b) https://bugzilla.redhat.com/show_bug.cgi?id=1495971
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SIGKILL signal cannot be trapped or ignored, so we shouldn't try. Newer versions of Ruby will raise an exception if you try to trap this signal.