-
Notifications
You must be signed in to change notification settings - Fork 900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GAPRINDASHVILI] Prevent queueing things for a zone that doesn't exist in the region #18068
Conversation
Prevent queueing things for a zone that doesn't exist in the region https://bugzilla.redhat.com/show_bug.cgi?id=1635764 (cherry picked from commit 01c28d5)
@bdunne I'm assuming this one will cause test failures on the other repos gaprindashvili branch after merge, much the way the original one did on master, right? I'm good with this, but it might require a few PRs on other repos to fix. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, see my comment above though.
Is this everything? ManageIQ/manageiq-ui-classic#4669 (plus 2 PRs that go with this PR, ManageIQ/manageiq-api#472 and #18036) |
@simaishi Yes, I think that's all of them |
This backport also broke providers-kubernetes & providers-openshift. Took me a long time to diagnose, because chains of rails hooks lead to really disconnected symptoms (like what does Took me even longer to debug/fix. The root problem was the following stubbing all over kubernetes & openshift tests:
this was affecting the zone with which events were added to MiqQueue to be "default" but no such zone... So all these stubs can be replaced with the more robust setup (which we already use in some tests):
(done in ManageIQ/manageiq-providers-kubernetes@db9bdff but that's not the fix we'll use) For some reason only then, knowing |
Prevent queueing things for a zone that doesn't exist in the region
https://bugzilla.redhat.com/show_bug.cgi?id=1635764
(cherry picked from commit 01c28d5)
Based on #17987 (comment)