Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GAPRINDASHVILI] Fix "<select> per page" styling in patternfly 3.25 #362

Merged
merged 1 commit into from
May 31, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions app/javascript/react/screens/App/Overview/Overview.scss
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,19 @@ hr {
margin-left: initial;
}

// Patternfly 3.25 compatibility - comes from patternfly/patternfly#910, made specific to v2v for gaprindashvili
.miq-v2v .content-view-pf-pagination .form-group {
.pagination-pf-pagesize.bootstrap-select.btn-group,
.pagination-pf-pagesize.btn-group {
display: flex;
float: none;
margin-bottom: 0;
margin-left: 0;
margin-right: 5px;
width: auto;
}
}

// The below style could be moved to core for the ConfirmModal component (or first, to the CSS in patternfly-react for that)

.confirm-warning-icon {
Expand Down
4 changes: 4 additions & 0 deletions app/views/layouts/_full_center_v2v.html.haml
Original file line number Diff line number Diff line change
Expand Up @@ -3,3 +3,7 @@

.container-fluid.container-pf-nav-pf-vertical.container-pf-nav-pf-vertical-with-sub-menus{:style => "overflow: hidden; height: 100%;"}
= yield

:javascript
// gaprindashvili-specific hack to support v2v-specific styling even for dialogs (outside #reactRoot)
$('body').addClass('miq-v2v');