PT#149703867 standardjs/eslint swap #886
Conversation
|
cc @martinpovolny @dclarizio @himdel Just wanted you to be aware of the proposed "rules" changes here that may not be consistent with the OPs UI. EDIT: I see it was partially discussed in ManageIQ/manageiq#8781, so just compleing the notification loop :) |
|
@Fryguy yep did! and posted the pr 👍 😆 💘 |
|
This pull request is not mergeable. Please rebase and repush. |
8158a05 to
e7c13af
Compare
|
Checked commits AllenBW/manageiq-ui-service@8bcacf9~...e7c13af with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
@AllenBW could you tweak the code coverage a bit? |
|
@chriskacerguis I do not believe that should be done in this pr, If we end up wanting to roll the linting change back we would be decreasing code coverage. As no specific new functionality was added there is not a new feature to write tests for. |
|
Spoke to @AllenBW and I agree with your above comment. |
https://www.pivotaltracker.com/story/show/149703867
What just happened? https://standardjs.com/rules.html
A ss to demonstrate error reporting is as normal, browser and server console still show offending code
A ss showing we still build and run correctly (notice that url), ALSO super important 😆