API/http - explicitly send cookie for api requests #5203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whether a cookie gets sent via fetch depends on the value of `credentials`, the default value is however unspecified causing some people unable to log in (without getting logged out right away) when the cookie was not sent unifying the behaviour between http (which sent it since #3987), and API (which didn't since the changes in #5164)
|
👍 |
…h parameters merged the test with the helper as it was not used anywhere else, and updated to *not* mock `window.fetch`, but instead use `API.post`
|
Checked commits https://github.com/himdel/manageiq-ui-classic/compare/05fba848ed566219e1477eac4758ffcae58d7ad3~...d2465589ea99d63b655b49ab00bf9ee2c5b76fa3 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
👍 |
himdel
added a commit
to ZitaNemeckova/manageiq-ui-classic
that referenced
this pull request
Feb 15, 2019
the helper was removed in ManageIQ#5203 but I left a reference to it in jasmine config
himdel
added a commit
to ZitaNemeckova/manageiq-ui-classic
that referenced
this pull request
Feb 15, 2019
the helper was removed in ManageIQ#5203 but I left a reference to it in jasmine config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
whether a cookie gets sent via fetch depends on the value of
credentials,the default value is however unspecified causing some people unable to log in (without getting logged out right away) when the cookie was not sent
unifying the behaviour between http (which sent it since #3978),
and API (which didn't but should since the changes in #5164).
Cc @djberg96 - thanks for all the debugging! :)
Cc @hstastna - I think this will solve the problem you've been having too