Webpack - clean up loaders, support es6 in node_modules

[himdel]

Closes #3504

Lot of our webpack config still comes directly unchanged from webpacker.

2 problems: unused loaders for things like ERB & CoffeeScript, and not actually compiling ES6 from node_modules.

Dropping all mentions of coffescript and erb from the code,
unifying the test regexes,
and not excluding node_modules from compilation anymore :).

[himdel]

Cc @skateman - we're not really using coffeescript anywhere, are we?

[himdel]

Testing:

--- a/app/javascript/packs/application-common.js
+++ b/app/javascript/packs/application-common.js
@@ -13,3 +13,5 @@ window.MiqReact = Object.assign(window.MiqReact || {}, {
   mount: mount,
   componentRegistry: componentRegistry
 });
+
+require('proxy-polyfill');
diff --git a/package.json b/package.json
index 50b4d28fc..273ec531f 100644
--- a/package.json
+++ b/package.json
@@ -34,6 +34,7 @@
     "lodash": "^4.17.4",
     "ng-redux": "^3.5.2",
     "prop-types": "^15.6.0",
+    "proxy-polyfill": "^0.1.7",
     "react": "^16.2.0",
     "react-dom": "^16.2.0",
     "redux-devtools-extension": "^2.13.2",

Run yarn, webpack, and check the compiled manageiq/public/packs/manageiq-ui-classic/application-common.js.

If there's a line which says const unsafeHandler = handler;, this is broken :).
If the line says var unsafeHandler = handler;, this works as intended :).
If there's no such line you're testing it wrong :).

[skateman]

🚒 🔴 🚒 🔴 ActionCable depends on coffeescript, don't drop it please.

[miq-bot]

Checked commits https://github.com/himdel/manageiq-ui-classic/compare/eb4bfaadbbf244a5c6a4d49a7f5bc95a1d9f1aa7~...248d50913a9f347694f88f196f42b9ddb2b52337 with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 🏆

[himdel]

Aah.. but ActionCable does not go via Webpack right?

So, I can still drop the webpack loader but keep coffee-rails?

[skateman]

@himdel yes!

[himdel]

Thanks, dropped the last commit, should be fine now I hope :)

[skateman]

I will look into this, but as far as I remember cable wasn't working without coffee-rails included. Of course it is an option to load actioncable the same wat SUI does: through NPM.

[himdel]

I will look into this, but as far as I remember cable wasn't working without coffee-rails included. Of course it is an option to load actioncable the same wat SUI does: through NPM.

OK, that ..may actually make sense if we ever go full-NPM :). But I guess we can just keep coffee-rails for now :). Plenty of patternflier fish to fry :)

[skateman]