Ensures httpd error_log and access_log are seen by docker or oc logs commands #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
are also sent to the container's stdout/stderr. This allows the httpd pod logs to be accessed via docker logs or oc logs.
|
@fbladilo can I bother you to try out on openshift, works for me on minishift using either docker logs or oc logs command. |
|
/cc @bdunne - after many tries (and errors), this one worked for me. |
|
Checked commit abellotti@8e36ef1 with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0 |
bdunne
approved these changes
Nov 15, 2017
bdunne
approved these changes
Jan 15, 2018
simaishi
pushed a commit
that referenced
this pull request
Jan 15, 2018
Ensures httpd error_log and access_log are seen by docker or oc logs commands (cherry picked from commit b80cb34)
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated httpd application.conf config file so error_log and access_log also sent to the container's stdout/stderr. This allows the httpd pod logs to be accessed via docker logs or oc logs.