Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ActiveSupport versions into the test matrix #77

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

Fryguy
Copy link
Member

@Fryguy Fryguy commented Sep 26, 2024

@agrare This gem was missing the ActiveSupport versions in the test matrix, so this PR adds them in. I noticed your PR in #63 wasn't actually testing the various Rails versions, so this adds it. This is a precursor to you adding support 7.1+, so this PR doesn't add those in yet.

cc @jrafanie

@jrafanie
Copy link
Member

jrafanie commented Sep 26, 2024

yes, this is the best type of git conflict. I'll happily resolve it my local work.

@kbrock
Copy link
Member

kbrock commented Sep 26, 2024

Is it possible to remove some of these versions from the support matrix?
It builds quicker and uses less processor time (so it frees up time for our other jobs to run)

@jrafanie
Copy link
Member

Is it possible to remove some of these versions from the support matrix?
It builds quicker and uses less processor time (so it frees up time for our other jobs to run)

Yes, I'm doing some of that in a change similar to #63 for rails 7.1 and 7.2 support.

It's fine to drop EOL rubies/rails but this repo rarely runs and they're fast builds so EOL things is really the only reason to drop stuff from the matrix. Page 1 of the CI's github action page goes back to 3 months ago. ManageIQ/manageiq page 1 of the CI GHA page goes back to 3 days ago. In other words, we barely run tests on this repository.

@agrare
Copy link
Member

agrare commented Sep 26, 2024

Oh awesome I noticed that too but was able to test with 7.1 locally and was working through other issues with that.

@agrare agrare merged commit 95d948e into ManageIQ:master Sep 26, 2024
11 checks passed
@Fryguy
Copy link
Member Author

Fryguy commented Sep 26, 2024

Is it possible to remove some of these versions from the support matrix?
It builds quicker and uses less processor time (so it frees up time for our other jobs to run)

Yes, but this PR was just status quo. That being said the tests run in 20s each so aren't any overhead.

agrare added a commit that referenced this pull request Sep 30, 2024
Added
- Test with ruby 3.1 and 3.0 (#65)
- Add ActiveSupport versions into the test matrix (#77)
- Add a wrap method to support BroadcastLogger (#63)
@Fryguy Fryguy deleted the add_as_versions branch October 15, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants