-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ActiveSupport versions into the test matrix #77
Conversation
12e12c4
to
d52c72f
Compare
yes, this is the best type of git conflict. I'll happily resolve it my local work. |
Is it possible to remove some of these versions from the support matrix? |
Yes, I'm doing some of that in a change similar to #63 for rails 7.1 and 7.2 support. It's fine to drop EOL rubies/rails but this repo rarely runs and they're fast builds so EOL things is really the only reason to drop stuff from the matrix. Page 1 of the CI's github action page goes back to 3 months ago. ManageIQ/manageiq page 1 of the CI GHA page goes back to 3 days ago. In other words, we barely run tests on this repository. |
Oh awesome I noticed that too but was able to test with 7.1 locally and was working through other issues with that. |
Yes, but this PR was just status quo. That being said the tests run in 20s each so aren't any overhead. |
@agrare This gem was missing the ActiveSupport versions in the test matrix, so this PR adds them in. I noticed your PR in #63 wasn't actually testing the various Rails versions, so this adds it. This is a precursor to you adding support 7.1+, so this PR doesn't add those in yet.
cc @jrafanie