Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a document on installing the VMware VDDK on containers #1706

Merged
merged 1 commit into from
Dec 20, 2022

Conversation


3. Copy the tar file into the container-assets directory. For Example:
```bash
$ cp ~/Downloads/VMware-vix-disklib-7.0.1-16860560.x86_64.tar.gz /tmp/vddk_container/container-assets
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be a generic version value and we point to another document describing what versions of vddk we support and against which versions of vsphere? cc @agrare

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

################################################################################

### IMPORTANT: Modify the following image and tag as necessary to reflect the version that you're running
FROM docker.io/manageiq/manageiq-base-worker:latest
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this point to a non-existing image and tag so they can't forget to update this value?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

```bash
$ cd /tmp/vddk_container/
$ docker build . -t your_registry.example.com/namespace/manageiq-base-worker:latest_vddk
$ docker push your_registry.example.com/namespace/manageiq-base-worker:latest_vddk
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this example registry, image and tag. They can't forget to update it and the it's very clear what needs to be done here.

baseWorkerImage: your_registry.example.com/namespace/manageiq-base-worker:latest_vddk
```

The operator will now update the orchestrator and worker deployments to reflect this change.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do they need to do if we release a new image? Ideally, it's just changing the
FROM ... and updating the revision of their image tag they build and push, right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, they will need to rebuild anytime we update the image.

@miq-bot
Copy link
Member

miq-bot commented Dec 20, 2022

Checked commit bdunne@7271699 with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint
0 files checked, 0 offenses detected
Everything looks fine. 👍

Copy link
Member

@jrafanie jrafanie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jrafanie jrafanie merged commit d393d1d into ManageIQ:master Dec 20, 2022
@jrafanie jrafanie assigned jrafanie and unassigned Fryguy Dec 20, 2022
@bdunne bdunne deleted the vddk branch December 20, 2022 16:38
github-actions bot pushed a commit to ManageIQ/manageiq.github.io that referenced this pull request Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document building a new container image with VMware VixDiskLib Installed for vSphere SmartState
4 participants