Make container events belong to their container groups

[zeari]

BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1496179

part of ManageIQ/manageiq#16583

@cben @moolitayer @enoodle Please review

[gmcculloug]

@lfu Please review

[lfu]

LGTM 👍

[moolitayer]

I can't find where this event is created?

[zeari]

Looks like a weird git error.
container_created and container_failed got criss-crossed in file rename

Kubernetes.class/container_created.yaml → ...Kubernetes.class/pod_containerfailed.yaml
Kubernetes.class/container_failed.yaml → ...Kubernetes.class/pod_containercreated.yaml

[moolitayer]

OK didn't found where the POD prefix is being added. @zeari located it

[moolitayer]

LGTM 👍

[zeari]

@miq-bot add_label gaprindashvili/yes

[zeari]

@miq-bot add_label fine/yes

[Ladas]

@cben so adding the policies, we will likely see a lot of failures with target not found in log.

Should we first solve that target is always refreshed before running the policy?

[cben]

@cben <https://github.com/cben> so adding the policies, we will likely see a lot of failures with target not found in log.

Yes but same is true of existing Pod & Replicator policies support :-( They are nearly unusable. We need to add these events, and independently we need to solve event-before-refresh.

[miq-bot]

Checked commits zeari/manageiq-content@ab43065~...a6f4ba0 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0
12 files checked, 1 offense detected

**

• 💣 💥 🔥 🚒 - Linter/Yaml - missing config files

[zeari]

@lfu @gmcculloug Please merge.

[simaishi]

Gaprindashvili backport details:

$ git log -1
commit 36ef4dc36493d592d8d60256ab42498d72808623
Author: Greg McCullough <gmccullo@redhat.com>
Date:   Thu Dec 21 11:37:02 2017 -0500

    Merge pull request #225 from zeari/container_to_pod
    
    Make container events belong to their container groups
    (cherry picked from commit 1696ac15e4d25e94015819b11d36c3c490226531)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1530651

[zeari]

@simaishi how do fine backports work in relation to this change? Do I need to create a PR?

[simaishi]

@zeari If there is a conflict with cherry-pick, I will request a separate PR. Until then, nothing is needed.

[simaishi]

Fine backport details:

$ git log -1
commit c57a0175b40bbac87a51dde9a9b019fb663da9f9
Author: Greg McCullough <gmccullo@redhat.com>
Date:   Thu Dec 21 11:37:02 2017 -0500

    Merge pull request #225 from zeari/container_to_pod
    
    Make container events belong to their container groups
    (cherry picked from commit 1696ac15e4d25e94015819b11d36c3c490226531)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1530653