Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude specific -firmware packages only #311

Merged
merged 1 commit into from
Mar 21, 2019

Conversation

simaishi
Copy link
Contributor

We're currently excluding *-firmware packages. But linux-firmware is required by kernel and installed. Instead of excluding *-firmware, excluding all firmware that's not linux-firmware to avoid possible package conflict during install.

Mar 11 21:41:09 localhost packaging[1202]: deselect package *-firmware
...
Mar 11 21:41:14 localhost yum[1202]: TSINFO: Marking linux-firmware-20180911-69.git85c5d90.el7.noarch
as install for kernel-3.10.0-957.5.1.el7.x86_64

Verified only linux-firmware is present on the machine by running a build with this change.

@miq-bot
Copy link
Member

miq-bot commented Mar 20, 2019

Checked commit simaishi@4c0eff2 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 🍰

@carbonin carbonin merged commit 5b5e6f9 into ManageIQ:master Mar 21, 2019
@carbonin carbonin added this to the Sprint 108 Ending Apr 1, 2019 milestone Mar 21, 2019
@simaishi simaishi deleted the firmware_exclude branch March 21, 2019 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants