Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compress Azure, HyperV and EC2 images #289

Merged
merged 1 commit into from
Oct 5, 2018

Conversation

simaishi
Copy link
Contributor

@simaishi simaishi commented Oct 5, 2018

Azure, HyperV and EC2 images are not compressed during imagefactory build. zip compressing the images so the image size will be comparable to other images.

@adahms It might affect documentation, so fyi... This is upstream only change for now, and will go to Gaprindashvili and later branches.

@miq-bot
Copy link
Member

miq-bot commented Oct 5, 2018

Checked commit simaishi@de73e3e with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 👍

@carbonin carbonin self-assigned this Oct 5, 2018
@carbonin carbonin merged commit 52b8be9 into ManageIQ:master Oct 5, 2018
@carbonin carbonin added this to the Sprint 96 Ending Oct 8, 2018 milestone Oct 5, 2018
simaishi pushed a commit that referenced this pull request Oct 5, 2018
Compress Azure, HyperV and EC2 images

(cherry picked from commit 52b8be9)
@simaishi simaishi deleted the compress_images branch October 5, 2018 15:59
@simaishi
Copy link
Contributor Author

simaishi commented Oct 5, 2018

Hammer backport details:

$ git log -1
commit 806577c35db60283e79d841cd153428153aad38a
Author: Nick Carboni <ncarboni@redhat.com>
Date:   Fri Oct 5 11:19:12 2018 -0400

    Merge pull request #289 from simaishi/compress_images
    
    Compress Azure, HyperV and EC2 images
    
    (cherry picked from commit 52b8be90f5fb289b90fedc7e5b5fc37add335c96)

simaishi pushed a commit that referenced this pull request Oct 9, 2018
Compress Azure, HyperV and EC2 images

(cherry picked from commit 52b8be9)
@simaishi
Copy link
Contributor Author

simaishi commented Oct 9, 2018

Gaprindashvili backport details:

$ git log -1
commit 32966b45b828e071fc7556f1bb78a2d0f870127f
Author: Nick Carboni <ncarboni@redhat.com>
Date:   Fri Oct 5 11:19:12 2018 -0400

    Merge pull request #289 from simaishi/compress_images
    
    Compress Azure, HyperV and EC2 images
    
    (cherry picked from commit 52b8be90f5fb289b90fedc7e5b5fc37add335c96)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants