Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change config path to be relative to script #252

Merged
merged 1 commit into from
Nov 30, 2017

Conversation

simaishi
Copy link
Contributor

Changing path to config files to be relative to the vmbuild.rb script, rather than hard-coded /build/config as config dir contains files committed to git, which could be different for different branches

@miq-bot
Copy link
Member

miq-bot commented Nov 30, 2017

Checked commit simaishi@6abc613 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 🍰

@Fryguy Fryguy merged commit 9f59386 into ManageIQ:master Nov 30, 2017
@simaishi simaishi deleted the fix_config_path branch December 1, 2017 02:35
simaishi pushed a commit that referenced this pull request Dec 1, 2017
Change config path to be relative to script
(cherry picked from commit 9f59386)
@simaishi
Copy link
Contributor Author

simaishi commented Dec 1, 2017

Gaprindashvili backport details:

$ git log -1
commit 69cbc8bef0870a8b73612191271070e2f6581a29
Author: Jason Frey <fryguy9@gmail.com>
Date:   Thu Nov 30 18:42:00 2017 -0500

    Merge pull request #252 from simaishi/fix_config_path
    
    Change config path to be relative to script
    (cherry picked from commit 9f593868900c5d713c7dd601899847a29d525d23)

simaishi pushed a commit that referenced this pull request Dec 1, 2017
Change config path to be relative to script
(cherry picked from commit 9f59386)
@simaishi
Copy link
Contributor Author

simaishi commented Dec 1, 2017

Fine backport details:

$ git log -1
commit b7671a4c9759438c884715c6a493ef9e1d9f1982
Author: Jason Frey <fryguy9@gmail.com>
Date:   Thu Nov 30 18:42:00 2017 -0500

    Merge pull request #252 from simaishi/fix_config_path
    
    Change config path to be relative to script
    (cherry picked from commit 9f593868900c5d713c7dd601899847a29d525d23)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants