-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generic Object method calling #93
Generic Object method calling #93
Conversation
This pull request is not mergeable. Please rebase and repush. |
{ | ||
:method_name => action, | ||
:args => data['parameters'], | ||
:set_user => true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jntullo
Couldn't we just add the :user_id, :group_id, :tenant_id here.
I am guessing this call is only for calling the generic object methods
Checked commits jntullo/manageiq-api@376e1a2~...0ada42c with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0 |
{ | ||
:method_name => action, | ||
:args => data['parameters'], | ||
:set_user => true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jntullo Is this still needed? I think you replaced it with ':user'
Just kicked the tire here, LGTM !! Thanks @jntullo for this API Enhancement. 👍 |
Adds calling of custom automate methods on Generic Objects.
Dependent upon ManageIQ/manageiq#16077 and ManageIQ/manageiq-automation_engine#74
Sample response with custom actions
Sample request for calling a method with parameters
This request sends in two numbers as an array (2 and 3) and adds them together, which can be seen from the
task_results
when checking the task after automate has executed the method.Request:
Response:
Automate Method:
Response from checking the task after automate completed:
Sample call with output from automate.log:
@miq-bot add_label enhancement, wip
@miq-bot assign @abellotti