Allow Zones to be edited, deleted #691
Conversation
|
@abellotti, @lpichler, @martinpovolny Please review. |
|
|
||
| expect(response).to have_http_status(:forbidden) | ||
| end | ||
| end |
|
Checked commits https://github.com/djberg96/manageiq-api/compare/831bba8a609bf95784bc0de26bd9c648b9abcbd1~...110b267f7c110ac0f2a4ec4c49b7df1f91528ded with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
| super | ||
| end | ||
|
|
||
| private |
There was a problem hiding this comment.
I am a bit concerned about this being the same as this:
Well also the part above.
I think that the behavior should be moved to a/the? parent class or a mixin.
We can agree on merging this (and the 3rd one) and then refactor it once the functionality is there. If you prefer it that way.
WDYT?
There was a problem hiding this comment.
The fields actually aren't identical - created_at vs created_on. But yes, we should eventually try to put this into some common code.
|
ping @lpichler : merge? |
|
Hmm, I don't see where zones can be deleted in the UI unless I'm missing this. /cc @Fryguy @djberg96 @martinpovolny I think we should forgo the delete, and shift to white-listing editable attributes here. gotta match the UI unless there are new UI requirements. |
|
Looks like in the Settings.
though grayed out for current zone, what does API/Model return if the current zone is getting deleted ? |
|
@abellotti There's some logic in zone.rb that prevents a zone in use from being destroyed: https://github.com/ManageIQ/manageiq/blob/master/app/models/zone.rb#L243-L247 |
|
@djberg96 can this be |
|
@martinpovolny or @abellotti any objections to making it ivanchuk/yes? |
|
^ ping |
|
Let's say yes. :) |
Allow Zones to be edited, deleted (cherry picked from commit e9b1b2c) https://bugzilla.redhat.com/show_bug.cgi?id=1805844
|
Ivanchuk backport details: |
Followup to #690, and very similar.
This PR allows for Zones to be edited and deleted. The only significant difference between this one and #690 is that previously some of these actions were explicitly disabled.
Partially addresses https://bugzilla.redhat.com/show_bug.cgi?id=1753806