Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Append RBAC features for VMRC console request through the API #642

Merged
merged 1 commit into from
Aug 7, 2019
Merged

Append RBAC features for VMRC console request through the API #642

merged 1 commit into from
Aug 7, 2019

Conversation

skateman
Copy link
Member

@skateman skateman commented Aug 5, 2019 •
edited
Loading

Adding these features for exposing API support for requesting VMRC consoles.

Parent issue: ManageIQ/manageiq#18718
Depends on: ManageIQ/manageiq#19097
@miq-bot add_label hammer/no, changelog/yes, enhancement
@miq-bot add_reviewer @lpichler

@miq-bot miq-bot requested a review from lpichler August 5, 2019 10:40
@miq-bot
Copy link
Member

miq-bot commented Aug 5, 2019

Checked commit skateman@c5f7cd2 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. ⭐

@skateman skateman mentioned this pull request Aug 5, 2019
Merged
@skateman
Copy link
Member Author

skateman commented Aug 7, 2019

@miq-bot add_reviewer @abellotti

@miq-bot miq-bot requested a review from abellotti August 7, 2019 04:15
@skateman
Copy link
Member Author

skateman commented Aug 7, 2019

Waiting for PM to determine if this is ivanchuk/yes, but is ready to merge now.

@miq-bot rm_label pending core

@miq-bot
Copy link
Member

miq-bot commented Aug 7, 2019

@skateman Cannot remove the following label because they are not recognized: pending core

@lpichler lpichler added this to the Sprint 118 Ending Aug 19, 2019 milestone Aug 7, 2019
@lpichler lpichler merged commit f9bb012 into ManageIQ:master Aug 7, 2019
@skateman skateman deleted the api-vmrc-support branch August 7, 2019 14:22
@skateman
Copy link
Member Author

@miq-bot add_label ivanchuk/yes

@simaishi simaishi mentioned this pull request Aug 13, 2019
Merged
simaishi pushed a commit that referenced this pull request Aug 13, 2019
@lpichler @simaishi
Merge pull request #642 from skateman/api-vmrc-support
271130a 
Append RBAC features for VMRC console request through the API

(cherry picked from commit f9bb012)

https://bugzilla.redhat.com/show_bug.cgi?id=1740691
@simaishi
Copy link
Contributor

Ivanchuk backport details:

$ git log -1
commit 271130ad3ddfa8a966075f5cae6475d41ad88948
Author: Libor Pichler <lpichler@redhat.com>
Date:   Wed Aug 7 16:21:24 2019 +0200

    Merge pull request #642 from skateman/api-vmrc-support
    
    Append RBAC features for VMRC console request through the API
    
    (cherry picked from commit f9bb01225be6e503a0d8aa906e0eb193d587d4ce)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1740691

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abellotti abellotti abellotti approved these changes

@lpichler lpichler lpichler approved these changes

Assignees
No one assigned
Labels
changelog/yes enhancement hammer/no ivanchuk/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@skateman @miq-bot @simaishi @abellotti @lpichler