Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow api.yml to be pluggable #613

Merged
merged 1 commit into from
Jun 27, 2019
Merged

Conversation

Fryguy
Copy link
Member

@Fryguy Fryguy commented Jun 24, 2019

@abellotti Please review. I'd like to add tests, but not sure how yet.

@abellotti
Copy link
Member

LGTM!! Nice Enhancement @Fryguy 👍

@miq-bot
Copy link
Member

miq-bot commented Jun 24, 2019

Checked commit Fryguy@67e8dbc with ruby 2.3.3, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 👍

@bdunne bdunne merged commit aa2d4fe into ManageIQ:master Jun 27, 2019
@bdunne bdunne added this to the Sprint 115 Ending Jul 8, 2019 milestone Jun 27, 2019
@bdunne bdunne assigned bdunne and unassigned abellotti Jun 27, 2019
@Fryguy Fryguy deleted the pluggable_api_yml branch June 28, 2019 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants