Support physical server provisioning #578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 18, 2019
With this commit we implement two things:
a) expose necessary API calls so React can populate dropdowns
for provisioning dialog (when showing popup to user)
b) allow React to create Request of type PhysicalServerProvisionRequest
via API (when user clicks "Provision" on the popup)
To fulfil (a) we basically need following API calls:
```
/api/pxe_servers # offer user to pick PXE server
/api/pxe_servers/:id/pxe_images # offer user to pick image on selected server
/api/pxe_images/:id/customization_templates # offer user to pick template on selected image
```
And to fulfil (b) we basically need following API call to be accepted:
```
POST /api/requests
{
"options" : {
"request_type" : "provision_physical_server", # maps to PhysicalServerProvisionRequest
"src_ids": [1],
"pxe_image_id": 1,
"configuration_profile_id": 1
}
}
```
Signed-off-by: Miha Pleško <miha.plesko@xlab.si>
3a330b3 to
0256d55
Compare
|
Checked commit xlab-si@0256d55 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
@abellotti would you perhaps prefer if I split the PR into three smaller PRs? Currently it's kinda big, but I think those API calls belong together. However you prefer |
|
Reassigning to Gregg because I'm not sure who else to assign. Related miq-core and miq-automate PRs have been merged. @miq-bot assign @gtanzillo |
gtanzillo
approved these changes
Apr 30, 2019
There was a problem hiding this comment.
This looks good to me 👍 @abellotti, can you give it a quick look?
abellotti
approved these changes
Apr 30, 2019
|
yep, looks good here too. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this commit we implement two things:
To fulfil (1) we basically need following API calls:
And to fulfil (2) we basically need following API call to be accepted:
@miq-bot add_label enhancement
@miq-bot assign @abellotti