Bundled 447 and 452 to go green #454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Credentials created by EmsRefresh set the credential.manager to the AutomationManager not a Provider. This causes issues where credential.manager is expected to be an ExtManagementSystem type.
bf3b802 moved us away from user.is_admin? This is based upon the miq_request_superadmin feature. The UI used a different feature, miq_request_approval. This changes the feature identifier to make the UI and API the same. miq_request_superadmin will be deprecated https://bugzilla.redhat.com/show_bug.cgi?id=1608554
|
Checked commits kbrock/manageiq-api@4bfb191~...a88382b with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
gtanzillo
approved these changes
Aug 21, 2018
This was referenced Aug 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge of #447 and #452
Both need to be merged to get build 🍏