Expose CloudSubnet creation #440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @miha-plesko for the enhancement, this looks good. Maybe add a spec test when you get a chance. Thank you. |
2efe8b2 to
d2965ee
Compare
|
Apologies for delay @abellotti , added the tests just now. |
abellotti
approved these changes
Aug 6, 2018
|
Thanks @miha-plesko for the API Enhancement. LGTM!! 👍 |
|
Can you take care of the travis errors before I merge. Thanks. |
|
Kicking Travis because I think red Travis isn't caused by this PR. |
With this commit we allow user to create CloudSubnet via API.
Example request:
```
POST /api/providers/4/cloud_subnets HTTP/1.1
{
"action": "create",
"resource": {
"router_ref": "aae5c1ff-9860-4a56-bb01-e936a7086f5a",
"name": "My New Cloud Subnet",
"address": "130.130.130.0",
"netmask": "255.255.255.0",
"gateway": "130.130.130.1"
}
}
```
Signed-off-by: Miha Pleško <miha.plesko@xlab.si>
d2965ee to
b0a5110
Compare
|
Checked commit miha-plesko@b0a5110 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
@abellotti #446 should take care of the failing specs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this commit we allow user to create CloudSubnet via API. Example request:
(it's up to raw_create_cloud_subnet on each provider to decide what arguments are consumed, example above is for Nuage provider, see here https://github.com/ManageIQ/manageiq-providers-nuage/blob/master/app/models/manageiq/providers/nuage/network_manager/cloud_subnet.rb#L54-L61)
Needed for: ManageIQ/manageiq-providers-nuage#118
RFE BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1574972
@miq-bot add_label enhancement
@miq-bot assign @abellotti
/cc @Ladas @agrare
Assigning @abellotti since you merged last few PRs so I assume you're the guy - are you? 😃