Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Symbolize schedule data #436

Merged
merged 2 commits into from
Jul 30, 2018
Merged

Symbolize schedule data #436

merged 2 commits into from
Jul 30, 2018

Conversation

bdunne
Copy link
Member

@bdunne bdunne commented Jul 27, 2018 •
edited
Loading

Ensure the hash keys are symbolized before sending them to the model.

https://bugzilla.redhat.com/show_bug.cgi?id=1564255

@bdunne bdunne force-pushed the symbolize_schedule_data branch from 0499efd to cee1d2c Compare July 27, 2018 19:21
@bdunne
Copy link
Member Author

bdunne commented Jul 27, 2018

@abellotti Please review
@miq-bot add_labels gaprindashvili/yes bug

@miq-bot
Copy link
Member

miq-bot commented Jul 27, 2018

@bdunne Cannot apply the following label because they are not recognized: gaprindashvili/yes bug

@AllenBW AllenBW mentioned this pull request Jul 27, 2018
Merged
@AllenBW
Copy link
Member

AllenBW commented Jul 27, 2018

@miq-bot add_labels gaprindashvili/yes

@bdunne bdunne force-pushed the symbolize_schedule_data branch from cee1d2c to 6769679 Compare July 27, 2018 20:00
@bdunne bdunne force-pushed the symbolize_schedule_data branch from 6769679 to a3db9ee Compare July 27, 2018 20:19
@miq-bot
Copy link
Member

miq-bot commented Jul 27, 2018

Checked commits bdunne/manageiq-api@0be69b6~...a3db9ee with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. 👍

@AllenBW
Copy link
Member

AllenBW commented Jul 30, 2018

@miq-bot add_labels bug

@miq-bot miq-bot added the bug label Jul 30, 2018
@gtanzillo gtanzillo self-assigned this Jul 30, 2018
@gtanzillo gtanzillo added this to the Sprint 91 Ending Jul 30, 2018 milestone Jul 30, 2018
@gtanzillo gtanzillo merged commit 73b98a3 into ManageIQ:master Jul 30, 2018
@bdunne bdunne deleted the symbolize_schedule_data branch July 30, 2018 22:12
simaishi pushed a commit that referenced this pull request Jul 31, 2018
@gtanzillo @simaishi
Merge pull request #436 from bdunne/symbolize_schedule_data
bcbafb3 
Symbolize schedule data
(cherry picked from commit 73b98a3)

https://bugzilla.redhat.com/show_bug.cgi?id=1608351
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit bcbafb303bb8f503b3f321a10b26003680a3762a
Author: Gregg Tanzillo <gtanzill@redhat.com>
Date:   Mon Jul 30 18:06:04 2018 -0400

    Merge pull request #436 from bdunne/symbolize_schedule_data
    
    Symbolize schedule data
    (cherry picked from commit 73b98a3e34c42875784a24bb22c904f1670b8e91)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1608351

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@gtanzillo gtanzillo

Labels
blocker bug gaprindashvili/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bdunne @miq-bot @AllenBW @simaishi @gtanzillo