Ensure 'submit_workflow' is true when adding a service to a cart #426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d-m-u
approved these changes
Jul 18, 2018
gtanzillo
suggested changes
Jul 18, 2018
| @@ -90,7 +90,7 @@ def service_request_workflow(service_request) | |||
| raise BadRequestError, "Must specify a service_template_href for adding a service_request" | |||
| end | |||
| service_template = resource_search(service_template_id, :service_templates, ServiceTemplate) | |||
| service_template.provision_workflow(User.current_user, service_request) | |||
| service_template.provision_workflow(User.current_user, service_request, {:submit_workflow => true}) | |||
There was a problem hiding this comment.
Looks good but you can remove the curly braces around {:submit_workflow => true}
|
Some comments on commit eclarizio@a8049ae spec/requests/service_orders_spec.rb
|
|
@gtanzillo Changes made. As a side note, I really didn't want to use |
|
Checked commit eclarizio@a8049ae with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 spec/requests/service_orders_spec.rb
|
gtanzillo
approved these changes
Jul 18, 2018
gtanzillo
approved these changes
Jul 18, 2018
simaishi
pushed a commit
that referenced
this pull request
Jul 25, 2018
Ensure 'submit_workflow' is true when adding a service to a cart (cherry picked from commit 9d146dc) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1603029
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related to #406 which was meant to remove the automate calls from submit, but the SUI does not directly order the service, it instead adds the service to a cart before ordering. This caused an issue where the dialog field properties weren't being propagated correctly and so the validation was failing.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1601925
@miq-bot add_label gaprindashvili/yes, bug, blocker
@miq-bot assign @gtanzillo
@d-m-u Can you review?
@gtanzillo Please re-assign if you think someone else should be assigned.
/cc @tinaafitz