Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Creating PhysicalStorage controller and adding endpoint configuration #397

Merged
merged 1 commit into from
Jun 26, 2018
Merged

Creating PhysicalStorage controller and adding endpoint configuration #397

merged 1 commit into from
Jun 26, 2018

Conversation

EsdrasVP
Copy link
Member

This PR adds:

  • GET /api/physical_storages
  • GET /api/physical_storages/:id
  • POST /api/physical_storages (action: refresh)
  • POST /api/physical_storages/:id (action: refresh)

Depends on:

@EsdrasVP EsdrasVP changed the title Creating PhysicalStorage controller and adding endpoint configuration [WIP] Creating PhysicalStorage controller and adding endpoint configuration Jun 14, 2018
@miq-bot miq-bot added the wip label Jun 14, 2018
@EsdrasVP EsdrasVP changed the title [WIP] Creating PhysicalStorage controller and adding endpoint configuration Creating PhysicalStorage controller and adding endpoint configuration Jun 14, 2018
@miq-bot miq-bot removed the wip label Jun 14, 2018
@EsdrasVP EsdrasVP changed the title Creating PhysicalStorage controller and adding endpoint configuration [WIP] Creating PhysicalStorage controller and adding endpoint configuration Jun 15, 2018
@miq-bot miq-bot added the wip label Jun 15, 2018
@EsdrasVP EsdrasVP force-pushed the enable_storage_api_endpoint branch from 702b000 to 80be0eb Compare June 15, 2018 12:34
@EsdrasVP EsdrasVP changed the title [WIP] Creating PhysicalStorage controller and adding endpoint configuration Creating PhysicalStorage controller and adding endpoint configuration Jun 18, 2018
@miq-bot miq-bot removed the wip label Jun 18, 2018
@EsdrasVP EsdrasVP mentioned this pull request Jun 19, 2018
Merged
@miq-bot
Copy link
Member

miq-bot commented Jun 20, 2018

This pull request is not mergeable. Please rebase and repush.

@EsdrasVP EsdrasVP force-pushed the enable_storage_api_endpoint branch from 80be0eb to 2187dac Compare June 21, 2018 13:58
@EsdrasVP EsdrasVP force-pushed the enable_storage_api_endpoint branch from 2187dac to 1a1e880 Compare June 26, 2018 12:11
@EsdrasVP EsdrasVP closed this Jun 26, 2018
@EsdrasVP EsdrasVP reopened this Jun 26, 2018
@EsdrasVP EsdrasVP closed this Jun 26, 2018
@EsdrasVP EsdrasVP reopened this Jun 26, 2018
@EsdrasVP EsdrasVP force-pushed the enable_storage_api_endpoint branch from 1a1e880 to bf81ed1 Compare June 26, 2018 14:33
@miq-bot
Copy link
Member

miq-bot commented Jun 26, 2018

Checked commit EsdrasVP@bf81ed1 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 1 offense detected

app/controllers/api/physical_storages_controller.rb

@EsdrasVP
Copy link
Member Author

@miq-bot assign @abellotti

@abellotti abellotti added this to the Sprint 89 Ending Jul 2, 2018 milestone Jun 26, 2018
@abellotti
Copy link
Member

Thanks @EsdrasVP for the API Enhancement. LGTM!! 👍

@abellotti abellotti merged commit d826a71 into ManageIQ:master Jun 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abellotti abellotti abellotti approved these changes

Assignees

@abellotti abellotti

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@EsdrasVP @miq-bot @abellotti