Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Creating an endpoint for a PhysicalRack to execute toolbar actions #349

Merged
merged 1 commit into from
Jun 26, 2018
Merged

Creating an endpoint for a PhysicalRack to execute toolbar actions #349

merged 1 commit into from
Jun 26, 2018

Conversation

felipedf
Copy link
Member

@felipedf felipedf commented Mar 15, 2018 •
edited
Loading

This PR is able to:

  • Create a Controller for a PhysicalRack to handle toolbar, get and post actions

@felipedf felipedf changed the title Creating a endpoint for a PhysicalRack to execute toolbar actions [WIP] Creating a endpoint for a PhysicalRack to execute toolbar actions Mar 15, 2018
@miq-bot miq-bot added the wip label Mar 15, 2018
@felipedf felipedf changed the title [WIP] Creating a endpoint for a PhysicalRack to execute toolbar actions [WIP] Creating an endpoint for a PhysicalRack to execute toolbar actions Apr 19, 2018
@miq-bot
Copy link
Member

miq-bot commented May 23, 2018

This pull request is not mergeable. Please rebase and repush.

@felipedf felipedf force-pushed the rack_toolbar_actions branch 2 times, most recently from 0f7179b to 8972ab8 Compare May 25, 2018 19:13
@felipedf felipedf changed the title [WIP] Creating an endpoint for a PhysicalRack to execute toolbar actions Creating an endpoint for a PhysicalRack to execute toolbar actions May 30, 2018
@miq-bot miq-bot removed the wip label May 30, 2018
@felipedf felipedf force-pushed the rack_toolbar_actions branch from 8972ab8 to 4c0cd6b Compare May 30, 2018 18:50
@felipedf felipedf closed this Jun 4, 2018
@felipedf felipedf reopened this Jun 4, 2018
@felipedf
Copy link
Member Author

felipedf commented Jun 5, 2018

@miq-bot assign @abellotti

@felipedf felipedf force-pushed the rack_toolbar_actions branch 3 times, most recently from 4b54130 to 9b8eb5b Compare June 12, 2018 18:09
@himdel himdel mentioned this pull request Jun 13, 2018
Merged
@himdel
Copy link
Contributor

himdel commented Jun 13, 2018 •
edited
Loading

Looks like the test failure is unrelated, caused by ManageIQ/manageiq#17550

(and hopefully fixed by #395)

@felipedf
Copy link
Member Author

@gtanzillo can you review this PR? 😄

@himdel
Copy link
Contributor

himdel commented Jun 22, 2018 •
edited
Loading

(@felipedf you should be able to close & reopen to get travis green)

@felipedf felipedf closed this Jun 22, 2018
@felipedf felipedf reopened this Jun 22, 2018
@himdel
Copy link
Contributor

himdel commented Jun 25, 2018

@abellotti Can you take a look please?

@abellotti
Copy link
Member

I think this looks good. we do needs tests.

@abellotti abellotti requested a review from gtanzillo June 25, 2018 18:31
@felipedf felipedf force-pushed the rack_toolbar_actions branch from 9b8eb5b to 1cc7452 Compare June 26, 2018 14:24
@miq-bot
Copy link
Member

miq-bot commented Jun 26, 2018

Checked commit felipedf@1cc7452 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 1 offense detected

app/controllers/api/physical_racks_controller.rb

@felipedf
Copy link
Member Author

Tests added 😅

@abellotti abellotti added this to the Sprint 89 Ending Jul 2, 2018 milestone Jun 26, 2018
@abellotti
Copy link
Member

Thanks @felipedf for adding the tests and the API Enhancement. LGTM!! 👍

@gtanzillo can we borrow your 👀 for a review ? Thanks.

gtanzillo
gtanzillo approved these changes Jun 26, 2018
View reviewed changes
Copy link
Member

@gtanzillo gtanzillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me too 👍

@abellotti abellotti merged commit 28abd69 into ManageIQ:master Jun 26, 2018
@felipedf felipedf deleted the rack_toolbar_actions branch June 27, 2018 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gtanzillo gtanzillo gtanzillo approved these changes

@abellotti abellotti abellotti approved these changes

Assignees

@abellotti abellotti

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@felipedf @miq-bot @himdel @abellotti @gtanzillo