-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding support for /api/containers primary collection. #332
Conversation
ping @h-kataria couldn't find the individual resource's product feature: so just using the List. Is this something we need to add to the product features, i.e. adding a Show identifier for Containers ? Thanks. |
30cbb40
to
634bc03
Compare
@abellotti looks like a "Show" feature is missing for Individual Container object, should have been a feature similar to https://github.com/ManageIQ/manageiq/blob/master/db/fixtures/miq_product_features.yml#L3639-L3642 |
GET /api/containers GET /api/containers/:id POST /api/containers - bulk action "query" https://bugzilla.redhat.com/show_bug.cgi?id=1549661
634bc03
to
a993ae1
Compare
Needs ManageIQ/manageiq#17074 to be merged first for the container_show product feature. |
Checked commit abellotti@a993ae1 with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0 |
LGTM! 👍 |
Adding support for /api/containers primary collection. (cherry picked from commit 43def71) https://bugzilla.redhat.com/show_bug.cgi?id=1552809
Gaprindashvili backport details:
|
Adding support for /api/containers primary collection
GET /api/containers
GET /api/containers/:id
POST /api/containers - bulk action "query"
Requires: ManageIQ/manageiq#17074
https://bugzilla.redhat.com/show_bug.cgi?id=1549661