Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow read-only access to quotas subcollection #283

Merged
merged 1 commit into from
Jan 23, 2018

Conversation

jntullo
Copy link

@jntullo jntullo commented Jan 15, 2018

This change allows read-only access to the quotas subcollection on tenants

BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1535556

@miq-bot add_label gaprindashvili/yes
@miq-bot assign @abellotti

This change will allow only read access to quotas by allowing anybody with tenant read access to also read their quotas
@jntullo jntullo changed the title Fix product features for tenant quotas Allow read-only access to quotas subcollection Jan 15, 2018
@miq-bot
Copy link
Member

miq-bot commented Jan 15, 2018

Checked commit jntullo@53aa248 with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 🍰

@abellotti
Copy link
Member

@jntullo LGTM!! can we get this PR's tires kicked by who reported the issue ? would like to make sure before we merge as it is also g/yes. Thanks.

@jntullo
Copy link
Author

jntullo commented Jan 15, 2018

cc @ITD27M01 - can you review and see if this resolves your issue for read-only on quotas? Thanks!

@ITD27M01
Copy link

@jntullo Thank you! Is there any way to get this backported to fine and to CFME 5.8 ?

@jntullo
Copy link
Author

jntullo commented Jan 18, 2018

BZ for Fine backport: https://bugzilla.redhat.com/show_bug.cgi?id=1535556

@miq-bot add_label fine/yes

@abellotti
Copy link
Member

Ping @ITD27M01 any update on your testing ? Did the fix work for you ?

@ITD27M01
Copy link

@abellotti I have checked this on CFME 5.8.2 appliance (MIQ FIne) and seems it works fine, but I want to get users response for this. I provided access to some users to a test environment and wait for their response.

@abellotti abellotti added this to the Sprint 78 Ending Jan 29, 2018 milestone Jan 23, 2018
@abellotti
Copy link
Member

LGTM!! Thanks @jntullo for fixing this and @ITD27M01 for checking it out. 👍

@abellotti abellotti merged commit 9f9f4ee into ManageIQ:master Jan 23, 2018
@abellotti abellotti added the bug label Jan 23, 2018
@jntullo jntullo deleted the quota_product_features branch February 14, 2018 19:35
@simaishi
Copy link
Contributor

simaishi commented Mar 5, 2018

Fine backport (to manageiq repo) details:

$ git log -1
commit c9069c107c1da93f08827be4f3428da0dbf437c3
Author: Alberto Bellotti <abellotti@users.noreply.github.com>
Date:   Tue Jan 23 11:07:38 2018 -0500

    Merge pull request #283 from jntullo/quota_product_features
    
    Allow read-only access to quotas subcollection
    (cherry picked from commit 9f9f4ee94265c35dff43392725517dca19ac7d48)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1550737

@simaishi simaishi removed the fine/yes label Mar 5, 2018
simaishi pushed a commit that referenced this pull request Mar 6, 2018
Allow read-only access to quotas subcollection
(cherry picked from commit 9f9f4ee)

https://bugzilla.redhat.com/show_bug.cgi?id=1550736
@simaishi
Copy link
Contributor

simaishi commented Mar 6, 2018

Gaprindashvili backport details:

$ git log -1
commit a3551dab791d39e1856fcf6a7fa7ec7cb6945ef4
Author: Alberto Bellotti <abellotti@users.noreply.github.com>
Date:   Tue Jan 23 11:07:38 2018 -0500

    Merge pull request #283 from jntullo/quota_product_features
    
    Allow read-only access to quotas subcollection
    (cherry picked from commit 9f9f4ee94265c35dff43392725517dca19ac7d48)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1550736

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants